diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..7c8b71f --- /dev/null +++ b/.gitignore @@ -0,0 +1,5 @@ +/bin/ +/target/ +/.classpath +/.project +/.settings/ \ No newline at end of file diff --git a/pom.xml b/pom.xml index 295ef68..1be93ee 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ org.commonjava.mimeparse mimeparse - 0.1.4-SNAPSHOT + 0.2.0-SNAPSHOT mimeparse http://github.com/jdcasey/mimeparse/ @@ -32,6 +32,13 @@ + + Andrew Norman + normana400 + + fork-maintainer + + John Casey jdcasey @@ -51,11 +58,15 @@ - commons-lang - commons-lang - 2.4 - compile + org.apache.commons + commons-lang3 + 3.18.0 + + org.apache.commons + commons-math3 + 3.6.1 + junit junit @@ -69,19 +80,18 @@ maven-compiler-plugin - 3.1 + 3.14.0 - 1.7 - 1.7 + 1.8 + 1.8 maven-release-plugin - 2.4.1 + 3.1.1 forked-path false - -Prelease diff --git a/src/main/java/org/commonjava/mimeparse/MIMEParse.java b/src/main/java/org/commonjava/mimeparse/MIMEParse.java index 5d72a56..4f37e14 100644 --- a/src/main/java/org/commonjava/mimeparse/MIMEParse.java +++ b/src/main/java/org/commonjava/mimeparse/MIMEParse.java @@ -7,8 +7,8 @@ import java.util.List; import java.util.Map; -import org.apache.commons.lang.StringUtils; -import org.apache.commons.lang.math.NumberUtils; +import org.apache.commons.lang3.math.NumberUtils; +import org.apache.commons.lang3.StringUtils; /** * MIME-Type Parser @@ -251,8 +251,7 @@ public static String bestMatch(Collection supported, String header) FitnessAndQuality lastOne = weightedMatches .get(weightedMatches.size() - 1); - return NumberUtils.compare(lastOne.quality, 0) != 0 ? lastOne.mimeType - : ""; + return Float.compare(lastOne.quality, 0f) != 0 ? lastOne.mimeType : ""; } // hidden diff --git a/src/test/java/org/commonjava/mimeparse/MIMEParseTest.java b/src/test/java/org/commonjava/mimeparse/MIMEParseTest.java index 735dbc2..9494dc3 100644 --- a/src/test/java/org/commonjava/mimeparse/MIMEParseTest.java +++ b/src/test/java/org/commonjava/mimeparse/MIMEParseTest.java @@ -5,7 +5,7 @@ import junit.framework.TestCase; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; public class MIMEParseTest extends TestCase { @@ -24,10 +24,10 @@ public void testParseMediaRange() .parseMediaRange("application/xml;q=").toString()); assertEquals("('application', 'xml', {'q':'1',})", MIMEParse .parseMediaRange("application/xml ; q=").toString()); - assertEquals("('application', 'xml', {'b':'other','q':'1',})", + assertEquals("('application', 'xml', {'q':'1','b':'other',})", MIMEParse.parseMediaRange("application/xml ; q=1;b=other") .toString()); - assertEquals("('application', 'xml', {'b':'other','q':'1',})", + assertEquals("('application', 'xml', {'q':'1','b':'other',})", MIMEParse.parseMediaRange("application/xml ; q=2;b=other") .toString()); // Java URLConnection class sends an Accept header that includes a