Settings links in Release Notes do nothing (microsoft#268455)

* Settings links in Release Notes do nothing
Part of microsoft#268443

* Update src/vs/workbench/contrib/update/test/browser/releaseNotesRenderer.test.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix test

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: alexr00

src/vs/workbench/contrib/update/browser/releaseNotesEditor.ts

@@ -626,8 +626,10 @@ export async function renderReleaseNotesMarkdown(
 		sanitizerConfig: {
 			allowRelativeMediaPaths: true,
 			allowedLinkProtocols: {
-				override: [Schemas.http, Schemas.https, Schemas.command]
-			}
+				override: [Schemas.http, Schemas.https, Schemas.command, Schemas.codeSetting]
+			},
+			allowedTags: { augment: ['nav', 'svg', 'path'] },
+			allowedAttributes: { augment: ['aria-role', 'viewBox', 'fill', 'xmlns', 'd'] }
 		},
 		markedExtensions: [{
 			renderer: {

src/vs/workbench/contrib/update/test/browser/__snapshots__/Release_notes_renderer_Should_render_TOC.0.snap

@@ -10,12 +10,12 @@
 <p>text</p>
 </blockquote>
 <div class="toc-nav-layout">
-    
+    <nav id="toc-nav">
         <div>In this update</div>
         <ul>
             <li><a href="#chat">test</a></li>
         </ul>
-    
+    </nav>
     <div class="notes-main">
 
 <h2 id="test">Test</h2>

src/vs/workbench/contrib/update/test/browser/__snapshots__/Release_notes_renderer_Should_render_code_settings.0.snap

@@ -0,0 +1,7 @@
+<p>Here is a setting: <code tabindex="0"><a aria-role="button" title="View or change setting" class="codesetting" href="code-setting://editor.wordWrap/on"><svg fill="currentColor" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 15 15" height="14" width="14"><path d="M9.1 4.4L8.6 2H7.4l-.5 2.4-.7.3-2-1.3-.9.8 1.3 2-.2.7-2.4.5v1.2l2.4.5.3.8-1.3 2 .8.8 2-1.3.8.3.4 2.3h1.2l.5-2.4.8-.3 2 1.3.8-.8-1.3-2 .3-.8 2.3-.4V7.4l-2.4-.5-.3-.8 1.3-2-.8-.8-2 1.3-.7-.2zM9.4 1l.5 2.4L12 2.1l2 2-1.4 2.1 2.4.4v2.8l-2.4.5L14 12l-2 2-2.1-1.4-.5 2.4H6.6l-.5-2.4L4 13.9l-2-2 1.4-2.1L1 9.4V6.6l2.4-.5L2.1 4l2-2 2.1 1.4.4-2.4h2.8zm.6 7c0 1.1-.9 2-2 2s-2-.9-2-2 .9-2 2-2 2 .9 2 2zM8 9c.6 0 1-.4 1-1s-.4-1-1-1-1 .4-1 1 .4 1 1 1z"></path></svg>
+			<span class="separator"></span>
+			<span class="setting-name">editor.wordWrap</span>
+		</a></code> and another <code tabindex="0"><a aria-role="button" title="View or change setting" class="codesetting" href="code-setting://editor.wordWrap/off"><svg fill="currentColor" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 15 15" height="14" width="14"><path d="M9.1 4.4L8.6 2H7.4l-.5 2.4-.7.3-2-1.3-.9.8 1.3 2-.2.7-2.4.5v1.2l2.4.5.3.8-1.3 2 .8.8 2-1.3.8.3.4 2.3h1.2l.5-2.4.8-.3 2 1.3.8-.8-1.3-2 .3-.8 2.3-.4V7.4l-2.4-.5-.3-.8 1.3-2-.8-.8-2 1.3-.7-.2zM9.4 1l.5 2.4L12 2.1l2 2-1.4 2.1 2.4.4v2.8l-2.4.5L14 12l-2 2-2.1-1.4-.5 2.4H6.6l-.5-2.4L4 13.9l-2-2 1.4-2.1L1 9.4V6.6l2.4-.5L2.1 4l2-2 2.1 1.4.4-2.4h2.8zm.6 7c0 1.1-.9 2-2 2s-2-.9-2-2 .9-2 2-2 2 .9 2 2zM8 9c.6 0 1-.4 1-1s-.4-1-1-1-1 .4-1 1 .4 1 1 1z"></path></svg>
+			<span class="separator"></span>
+			<span class="setting-name">editor.wordWrap</span>
+		</a></code></p>

src/vs/workbench/contrib/update/test/browser/releaseNotesRenderer.test.ts

@@ -10,7 +10,10 @@ import { IContextMenuService } from '../../../../../platform/contextview/browser
 import { TestInstantiationService } from '../../../../../platform/instantiation/test/common/instantiationServiceMock.js';
 import { IExtensionService } from '../../../../services/extensions/common/extensions.js';
 import { SimpleSettingRenderer } from '../../../markdown/browser/markdownSettingRenderer.js';
+import { IPreferencesService } from '../../../../services/preferences/common/preferences.js';
 import { renderReleaseNotesMarkdown } from '../../browser/releaseNotesEditor.js';
+import { URI } from '../../../../../base/common/uri.js';
+import { Emitter } from '../../../../../base/common/event.js';
 
 
 suite('Release notes renderer', () => {
@@ -55,4 +58,48 @@ Navigation End -->
 		const result = await renderReleaseNotesMarkdown(content, extensionService, languageService, instantiationService.createInstance(SimpleSettingRenderer));
 		await assertSnapshot(result.toString());
 	});
+
+	test('Should render code settings', async () => {
+		// Stub preferences service with a known setting so the SimpleSettingRenderer treats it as valid
+		const testSettingId = 'editor.wordWrap';
+		instantiationService.stub(IPreferencesService, <Partial<IPreferencesService>>{
+			_serviceBrand: undefined,
+			onDidDefaultSettingsContentChanged: new Emitter<URI>().event,
+			userSettingsResource: undefined as any,
+			workspaceSettingsResource: null,
+			getFolderSettingsResource: () => null,
+			createPreferencesEditorModel: async () => null,
+			getDefaultSettingsContent: () => undefined,
+			hasDefaultSettingsContent: () => false,
+			createSettings2EditorModel: () => { throw new Error('not needed'); },
+			openPreferences: async () => undefined,
+			openRawDefaultSettings: async () => undefined,
+			openSettings: async () => undefined,
+			openApplicationSettings: async () => undefined,
+			openUserSettings: async () => undefined,
+			openRemoteSettings: async () => undefined,
+			openWorkspaceSettings: async () => undefined,
+			openFolderSettings: async () => undefined,
+			openGlobalKeybindingSettings: async () => undefined,
+			openDefaultKeybindingsFile: async () => undefined,
+			openLanguageSpecificSettings: async () => undefined,
+			getEditableSettingsURI: async () => null,
+			getSetting: (id: string) => {
+				if (id === testSettingId) {
+					// Provide the minimal fields accessed by SimpleSettingRenderer
+					return <any>{
+						key: testSettingId,
+						value: 'off',
+						type: 'string'
+					};
+				}
+				return undefined;
+			},
+			createSplitJsonEditorInput: () => { throw new Error('not needed'); }
+		});
+
+		const content = `Here is a setting: \`setting(${testSettingId}:on)\` and another \`setting(${testSettingId}:off)\``;
+		const result = await renderReleaseNotesMarkdown(content, extensionService, languageService, instantiationService.createInstance(SimpleSettingRenderer));
+		await assertSnapshot(result.toString());
+	});
 });