Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social platform icons now restricted to Font Awesome library fa-brands #843

Open
pfirpfel opened this issue Feb 12, 2025 · 3 comments
Open

Comments

@pfirpfel
Copy link

Regarding #839:

I understand that in most cases, this feature is now much simpler to use. But you are limited on what brand icons fontawesome has.

Would it be possible to still support the old icon system as a fallback?
Or not limit the icons to the fa-brands namespace in fontawesome? In my case being able to switch to fa-regular instead of fa-brands would be enough.

@ashmaroli
Copy link
Member

We don't intend to support the old icon system alongside the current Font Awesome based system due to reasons mentioned in #839. Limiting support to just fa-brands was a conscious decision.

However, I am curious as to which fa-regular icons you intend to render as part of the social-icons list. If its the envelop icon to denote email, then I believe that is duplicating the info rendered elsewhere in the footer itself. You are free to customize the _includes/footer.html to change the rendering of footer or just _includes/social.html at your end if you want to render the envelop icon as part of social-links.

@pfirpfel
Copy link
Author

I used to have more or less fa-calendar as an icon. But then it would need fa-brands changed into fa-regular. Same for fa-envelope.

I guess right now, the only way is to override the includes as you said. Being able to override the fontawesome "namespace" (fa-brands being the default) per social item would be cool though.

@pfirpfel
Copy link
Author

pfirpfel commented Feb 12, 2025

This is how I solved it in my social.html for now:

<span class="grey fa-{{ entry.fa_namespace | default: "brands" }} fa-{{ entry.icon }} fa-lg"></span>

Example config:

minima:
  social_links:
    - title: Jekyll repository at GitHub
      icon: github
      url: "https://github.com/jekyll/jekyll"
    - title: Jekyll at X (formerly Twitter)
      icon: x-twitter
      url: "https://x.com/jekyllrb"
    - title: Email Jekyll
      icon: envelope
      fa_namespace: regular
      url: "mailto:[email protected]"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants