Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review workflow and use python script to put en_us and zh_cn content togerther #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuezhuangshi
Copy link
Contributor

Submitter checklist

Here is an online tool which can help you to do the review work.

Desired reviewers

@jenkinsci/chinese-localization-sig

Description

close #114

使用 workflow 和 python 脚本将变更文件的原始内容和中文内容以 markdown 的形式评论在 PR 中,方便 review。

实现效果可参考:yuezhuangshi#14 (comment)

已知问题:

  • 目前无法精确识别到行改动,只能以文件级别将原始内容和中文内容评论在 PR 中
  • 英文文件是将中文文件的 _zh_CN 去掉来寻找的,例如:core/src/main/resources/widgets/HistoryPageFilter/queue-items.zh_CN.properties 对应的原始文件为 core/src/main/resources/widgets/HistoryPageFilter/queue-items.properties,可能会存在找不到的情况(源仓库中可能只有 .jelly,而没有 .properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

考虑如何自动给 PR 中的 ASCII 添加对应的中文,方便 review
1 participant