fix: terraform init before validate

Author: jhackshaw

.github/workflows/deploy.yml

@@ -6,8 +6,8 @@ on:
       - master
 
 env:
-  AWS_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY }}
-  AWS_SECRET_KEY: ${{ secrets.AWS_SECRET_KEY }}
+  AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }}
+  AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_KEY }}
   TF_VAR_geoip_account_id: ${{ secrets.TF_VAR_GEOIP_ACCOUNT_ID }}
   TF_VAR_geoip_license_key: ${{ secrets.TF_VAR_GEOIP_LICENSE_KEY }}
   TF_VAR_state_bucket: ${{ secrets.TF_VAR_STATE_BUCKET }}
@@ -25,15 +25,15 @@ jobs:
       - name: Check Format
         run: terraform fmt -check -diff
 
-      - name: Validate
-        run: terraform validate
-
       - name: Bootstrap
         run: ./bootstrap.sh
 
       - name: Init Terraform
         run: terraform init -input=false
 
+      - name: Validate
+        run: terraform validate
+
       - name: Deploy Infrastructure
         run: terraform apply -input=false -auto-approve
 

infrastructure/bootstrap.sh

@@ -1,9 +1,9 @@
 #/bin/bash
 
-if aws s3api head-bucket --bucket "$TF_VAR_state_bucket" 2>/dev/null;
+if aws s3api head-bucket --bucket "iplocate-terraform-state" 2>/dev/null;
 then
   echo "skiping create state bucket"
 else
   echo "creating bucket for terraform state"
-  aws s3api create-bucket --acl private --bucket "$TF_VAR_state_bucket"
+  aws s3api create-bucket --acl private --bucket "iplocate-terraform-state"
 fi

infrastructure/main.tf

@@ -1,8 +1,8 @@
 terraform {
   backend "s3" {
-    bucket = var.state_bucket
-    key    = var.state_bucket_key
-    region = var.aws_region
+    bucket = "iplocate-terraform-state"
+    key    = "tfstate"
+    region = "us-east-1"
   }
 }