Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanar-testnet section shows unexpected behaviour #147

Open
shashankcoc opened this issue Jun 21, 2024 · 8 comments
Open

Vanar-testnet section shows unexpected behaviour #147

shashankcoc opened this issue Jun 21, 2024 · 8 comments

Comments

@shashankcoc
Copy link
Contributor

shashankcoc commented Jun 21, 2024

While opening vanar-testnet it takes up a whole section of the screen, it should have scroll functionality.

Adding scroll functionality will make the web app more readable.

image

image

Similarly for this Search section also.

image

can I work on this issue ? @lazycoder1

@lazycoder1
Copy link
Collaborator

Go for it ser !

@shashankcoc
Copy link
Contributor Author

image

Hi, I have added the scroll functionality to both of the options and search component.
Just wanted to know for which branch I should raise Pull request bcoz I can't find any UI related branch.

@lazycoder1
Copy link
Collaborator

Could you do it to the development please ?

@shashankcoc
Copy link
Contributor Author

shashankcoc commented Jun 22, 2024

ok sure!

created the PR #148
I have one question authorization check failed for vercel is it necessary to authorize and deploy ?

This fix include all other page fixes ->

Earlier:
image

Now
image

@NECROMANCER01
Copy link

NECROMANCER01 commented Jun 22, 2024

Hey Shashank,
Thanks for contributing, I took your solution and tried redesigning it in our design system.
Dropdown

Because there are too many networks to scroll through, I devised a solution.

  • Added search field into dropdown itself, user can click onto search field and type or scroll through.
    While adding input in search field, result will be shown right below the search field
  • The text field is set to max width of the available network, "Binance Smart Chain" which is 200px for 14px font size and 16px icon size.

Can you make those changes?
Let me know if you need the Figma file or other resources for reference.

@shashankcoc
Copy link
Contributor Author

Hi, yes a design figma would be helpful.

@NECROMANCER01
Copy link

Hey here is the prototype demo

Dropdown5.mp4

And here is the Figma file for the Dropdown feature, Prototype included

https://www.figma.com/design/YJCCv4Sb1laqAZ0g5D1GXf/JiffyScan---DropDown-Feature?node-id=0-1&t=ntUUYdRUckKjyf3u-1

Let me know if there's anything I can help

shashankcoc added a commit to shashankcoc/jiffyscan-frontend that referenced this issue Jun 24, 2024
@shashankcoc
Copy link
Contributor Author

Hii, Raised PR please check , #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants