Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support padding/margin between words #15

Open
naslundx opened this issue Aug 16, 2024 · 3 comments · May be fixed by #37
Open

Support padding/margin between words #15

naslundx opened this issue Aug 16, 2024 · 3 comments · May be fixed by #37
Assignees

Comments

@naslundx
Copy link
Collaborator

There is a padding value to make_word_cloud but it is not used. This should be used when filling text in rectangles.

@jimbarrett27
Copy link
Owner

Do we use one fixed value in pixels? Or relative to the font size?

@naslundx
Copy link
Collaborator Author

Interesting question! I think fixed value makes more sense... otherwise I'm wondering if we end up with either a) effectively 0 margin around the small words or b) too much padding for large words meaning no space in between the letters

@jimbarrett27
Copy link
Owner

I had imagined that the padding would basically work by not putting the word within some number of pixels of the edge of the available rectangle, which wouldn't be an issue for the larger words, but you're probably right for smaller words getting squeezed together. Let's try fixed and see how it looks

@jimbarrett27 jimbarrett27 self-assigned this Aug 22, 2024
@jimbarrett27 jimbarrett27 linked a pull request Aug 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants