Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectEndpoints with no selected endpoints should remove previously selected endpoint #2134

Open
maxired opened this issue Oct 18, 2022 · 1 comment

Comments

@maxired
Copy link
Contributor

maxired commented Oct 18, 2022

Description

When creating an application directly with the lib and on top jitsi-meet,
I should be able to remove all participants from the selectedEndpoints

Current behavior

when calling selectEndpoints with an empty array, a previously selected participants is still prioritised

Expected Behavior

when calling selectEndpoints with an empty array, no participants should be priorisited

Possible Solution

the selectEndpoints method should remove check about !this._selectedEndpoints.length and the constraints getter should return the default constraints instead of the previous one.

Steps to reproduce

Given a running conference running with the lib,

  • call selectParticipants on the conference object with an array containing a single participant : participants are selected
  • then call selectParticipants with an empty array: Participant are still selected.

note:
I also do not understand why when multiple participants are selected, we don't seem to send the list of selected participants. see here

@saghul
Copy link
Member

saghul commented Nov 15, 2022

If you want to receive no one you can set last N to zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants