From 0890c5d7f76b1d43d2d12058f4ce32783467d63a Mon Sep 17 00:00:00 2001 From: Sean Aery Date: Mon, 18 Oct 2021 10:53:39 -0400 Subject: [PATCH] Bugfix: evaluate pixel height as integers to avoid browser-specific subpixel calculation differences. See https://github.com/projectblacklight/arclight/issues/1027 for examples where Firefox would evaluate truncate.height() as 61.2, truncate_height as 61.1999... and thus not expand. --- responsiveTruncator.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/responsiveTruncator.js b/responsiveTruncator.js index 92725f7..fc79c7f 100644 --- a/responsiveTruncator.js +++ b/responsiveTruncator.js @@ -45,7 +45,7 @@ toggle_link.click(function(){ var text = toggle_link.text() == settings.more ? settings.less : settings.more; toggle_link.text(text); - if(truncate.height() == truncate_height){ + if(parseInt(truncate.height(), 10) <= parseInt(truncate_height), 10) { truncate.css({height: '100%'}) }else{ truncate.css({height: truncate_height})