Skip to content

Commander broken with nestjs v8 #1154

@uvera

Description

@uvera

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Potential Commit/PR that introduced the regression

3dcba7d

Versions

3.13.0 -> 3.14.0

Describe the regression

When upgrading to v3.14.0 which merged 3dcba7d, I get the following error

(node:465857) UnhandledPromiseRejectionWarning: TypeError: this.metadataScanner.getAllMethodNames is not a function
    at DiscoveryService.classMethodsWithMetaAtKey (/home/dusan/Projects/web-api/node_modules/@golevelup/nestjs-discovery/src/discovery.service.ts:171:33)

which is caused by fixing use of deprecated method scanFromPrototype golevelup/nestjs@92bf751

Minimum reproduction code

Expected behavior

Nest-commander should continue working with older nest versions.
Minor version upgrade is not expected to introduce breaking changes.

Other

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions