Skip to content

PR #1240 broke peer deps #1259

@ruscon

Description

@ruscon

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

This PR #1240 broke the mappings of required dependencies.

nest-commander@3.20.1 peer deps for nestjs are:

  "peerDependencies": {
    "@nestjs/common": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0",
    "@nestjs/core": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0"
  },

But @golevelup/nestjs-discovery@5.0.0 allows only nestjs v11

  "peerDependencies": {
    "@nestjs/common": "^11.0.20",
    "@nestjs/core": "^11.0.20"
  },

So, nest-commander should remove old nestjs versions from peer deps or downgrade the version of @golevelup/nestjs-discovery package at least to @golevelup/nestjs-discovery@4.0.3

  "peerDependencies": {
    "@nestjs/common": "^10.x || ^11.0.0",
    "@nestjs/core": "^10.x || ^11.0.0"
  },

Minimum reproduction code

└─┬ nest-commander 3.20.1
  └─┬ @golevelup/nestjs-discovery 5.0.0
    ├── ✕ unmet peer @nestjs/core@^11.0.20: found 10.4.20
    └── ✕ unmet peer @nestjs/common@^11.0.20: found 10.4.20

Expected behavior

no issues with peer deps

Package

  • nest-commander
  • nest-commander-schematics
  • nest-commander-testing

Package version

2.3.1

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions