Skip to content

Title bar icons should be handled just like activity bar #585

Description

@gdlx

Versions:

  • OS: Windows
  • VS Code version 1.117.0
  • Peacock Version 4.2.2

Describe the bug
The title bar icons color should be handled just like in the activity bar, meaning their color should be darkened if the title bar is light.

Currently, with a dark color theme, light icons are darkened in the activity bar but not in the title bar (see screenshot)

To Reproduce
Steps to reproduce the behavior:

  1. Install a dark theme with light title bar icons (eg. Bearded Theme Solarized in my screenshot but I have the issue with many dark themes)
  2. Use a Peacock lighty color (eg. #A1C032 in my screenshot)

Expected behavior
Title bar icons (and maybe the text too) should be darkened with the same color as in the activity bar.

Screenshots
The explained problem:
Image

The same theme without Peacock color set (note the activity bar icons are light too):
Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions