Skip to content

[Bug]: Installing extension blows away any existing workbench.colorCustomizations settings #687

Description

@pzelnip

Peacock Version

4.3.4

VS Code Version

Version: 1.129.1 (Universal)

Operating System

macOS

Is workbench.experimental.modernUI enabled?

Yes

Describe the bug

I had both workbench.experimental.modernUI enabled and disabled in some VS Code windows at the time of installing Peacock.

The issue though is I often colour my titlebars differently by repo. I installed Peacock as per a suggestion for getting the same titlebar colouring in the new UI, but now that I installed Peacock I've lost the colours I set on each repo in the old UI.

Installing an extension should not cause a loss of settings like this.

Steps to Reproduce

  1. Set "titleBar.activeBackground" in workspace settings on a few VS Code windows
  2. Install Peacock and pick a colour on one window.
  3. Then uninstall Peacock
  4. All "titleBar.activeBackground" settings across all repos that were open are now lost

Expected Behavior

If the user has "titleBar.activeBackground" set already, prompt the user when switching with Peacock to create a backup of settings, or otherwise provide some warning that the existing setting will be trumped.

Even doing a "copy settings.json to settings.json.bak" would be great, I'm now left with 5 windows that I have to recreate the titlebar colour on.

Screenshots

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions