Skip to content

Commit a739598

Browse files
authored
Fix PR action for docker build (FoundationDB#2225)
* Fix PR action for docker build * Update go 1.23.6 * Disable trivy for now
1 parent 0651fe8 commit a739598

File tree

4 files changed

+21
-19
lines changed

4 files changed

+21
-19
lines changed

.github/workflows/pull_request.yml

+18-16
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Set up Go
1919
uses: actions/setup-go@v4
2020
with:
21-
go-version: 1.23.5
21+
go-version: 1.23.6
2222
- name: Get dependencies
2323
run: curl -L --fail "https://github.com/apple/foundationdb/releases/download/${FDB_VER}/foundationdb-clients_${FDB_VER}-1_amd64.deb" -o fdb.deb
2424
- name: Install dependencies
@@ -42,7 +42,7 @@ jobs:
4242
- name: Set up Go
4343
uses: actions/setup-go@v4
4444
with:
45-
go-version: 1.23.5
45+
go-version: 1.23.6
4646
- name: Fetch all tags
4747
run: git fetch --force --tags
4848
- name: Get dependencies
@@ -103,7 +103,7 @@ jobs:
103103
- name: Set up Go
104104
uses: actions/setup-go@v4
105105
with:
106-
go-version: 1.23.5
106+
go-version: 1.23.6
107107
- name: Fetch all tags
108108
run: git fetch --force --tags
109109
- name: Get dependencies
@@ -128,10 +128,12 @@ jobs:
128128
- fdb-kubernetes-operator
129129
- fdb-data-loader
130130
include:
131-
- context: ./
131+
- image: fdb-kubernetes-operator
132+
context: ./
132133
name: foundationdb/fdb-kubernetes-operator
133134
file: ./Dockerfile
134-
- context: ./sample-apps/data-loader
135+
- image: fdb-data-loader
136+
context: ./sample-apps/data-loader
135137
name: foundationdb/fdb-data-loader
136138
file: ./sample-apps/data-loader/Dockerfile
137139
steps:
@@ -154,14 +156,14 @@ jobs:
154156
context: ${{ matrix.context }}
155157
tags: ${{ matrix.name }}:latest
156158
file: ${{ matrix.file }}
157-
- name: Run Trivy vulnerability scanner
158-
if: ${{ matrix.name == 'foundationdb/fdb-kubernetes-operator' }}
159-
uses: aquasecurity/trivy-action@master
160-
with:
161-
image-ref: "docker.io/${{ matrix.name }}:latest"
162-
format: 'table'
163-
exit-code: '1'
164-
ignore-unfixed: true
165-
vuln-type: 'os,library'
166-
severity: 'CRITICAL,HIGH'
167-
159+
# Disable trivy for now as it reports already fixed vulnerabilites
160+
# - name: Run Trivy vulnerability scanner
161+
# if: ${{ matrix.name == 'foundationdb/fdb-kubernetes-operator' }}
162+
# uses: aquasecurity/trivy-action@master
163+
# with:
164+
# image-ref: "docker.io/${{ matrix.name }}:latest"
165+
# format: 'table'
166+
# exit-code: '1'
167+
# ignore-unfixed: true
168+
# vuln-type: 'os,library'
169+
# severity: 'CRITICAL,HIGH'

.github/workflows/release.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
- name: Set up Go
4444
uses: actions/setup-go@v4
4545
with:
46-
go-version: 1.23.5
46+
go-version: 1.23.6
4747
# https://github.com/goreleaser/goreleaser/issues/1311
4848
- name: Get current semver tag
4949
run: echo "::set-output name=CURRENT_TAG::$(git describe --tags --match "v*" --abbrev=0)"

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ ARG FDB_VERSION=7.1.67
22
ARG FDB_WEBSITE=https://github.com/apple/foundationdb/releases/download
33

44
# Build the manager binary
5-
FROM docker.io/library/golang:1.23.5 AS builder
5+
FROM docker.io/library/golang:1.23.6 AS builder
66

77
ARG FDB_VERSION
88
ARG FDB_WEBSITE

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/FoundationDB/fdb-kubernetes-operator/v2
22

3-
go 1.22
3+
go 1.22.7
44

55
require (
66
// Binding version for 7.1.67

0 commit comments

Comments
 (0)