Upgrade used go version (FoundationDB#1417)

* Upgrade used go version

Author: johscheuer

.github/workflows/pull_request.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v1
         with:
-          go-version: 1.18.6
+          go-version: 1.19.2
       - uses: actions/cache@v2
         with:
           path: ~/go/pkg/mod
@@ -44,7 +44,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.18.6
+        go-version: 1.19.2
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
       with:
@@ -104,7 +104,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v1
       with:
-        go-version: 1.18.6
+        go-version: 1.19.2
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
       with:
@@ -126,10 +126,7 @@ jobs:
         # Install dependencies either from cache or freshly downloaded
         sudo dpkg -i fdb.deb
     - name: Run tests
-      # Currently the default runner has 2 vCPU:
-      # https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources
       env:
-        GOMAXPROCS: "2"
         TEST_RACE_CONDITIONS: "1"
       run: |
         make test

.github/workflows/release.yaml

@@ -43,7 +43,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v1
         with:
-          go-version: 1.18.6
+          go-version: 1.19.2
       #  https://github.com/goreleaser/goreleaser/issues/1311
       - name: Get current semver tag
         run: echo "::set-output name=CURRENT_TAG::$(git describe --tags --match "v*" --abbrev=0)"

.golangci.yml

@@ -2,43 +2,63 @@ issues:
   # don't skip warning about doc comments
   # don't exclude the default set of lint
   exclude-use-default: false
+  exclude:
+    - "ST1000: at least one file in a package should have a package comment"
   exclude-rules:
   # exclude deprecation warning otherwise we get an error for our own deprecations
-  - linters: [staticcheck]
+  - linters:
+    - staticcheck
     text: "SA1019:"
-  - linters: [ govet ]
+  - linters:
+    - govet
     text: 'declaration of "(err|ctx)" shadows declaration at'
+  - linters:
+      - revive
+    text: "package-comments: should have a package comment"
+  # TODO (johscheuer): Ignore those linting issues for now and change it once we cut a new major release.
+  - linters:
+      - stylecheck
+    text: "ST1003: const StorageEngineRocksDbExperimental"
+  - linters:
+      - stylecheck
+    text: "ST1003: const StorageEngineRocksDbV1"
 
 linters:
   disable-all: true
   # TODO(johscheuer): activate linters again and fix issues
   enable:
-    - deadcode
-    #- dupl
+    - asciicheck
+    - bodyclose
+    - depguard
+    - dogsled
     - errcheck
-    #- goconst
-    #- gocyclo
+#    - errorlint
+    - exportloopref
+#    - goconst
+#    - gocritic
+#    - gocyclo
     - gofmt
-    - goimports
-    - revive
-    #- gosec
+    #- goimports
+    - goprintffuncname
+#    - gosec
     - gosimple
     - govet
+    - importas
     - ineffassign
-    #- interfacer
-    #- lll
-    #- maligned
     - misspell
     - nakedret
+    - nilerr
+#    - nolintlint
     - prealloc
-    - exportloopref
+    - revive
+    - rowserrcheck
     - staticcheck
-    - structcheck
+    - stylecheck
     - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
+    - whitespace
 
 linters-settings:
   errcheck:
@@ -48,7 +68,13 @@ linters-settings:
   govet:
     enable:
       - shadow
+  staticcheck:
+    go: "1.19"
+  stylecheck:
+    go: "1.19"
+
 run:
-  deadline: 5m
+  timeout: 10m
   skip-files:
-    - ".*_generated.*.go$"
+    - "zz_generated.*\\.go$"
+  allow-parallel-runners: true

Dockerfile

@@ -1,7 +1,7 @@
 ARG BASE_IMAGE=docker.io/debian:bullseye
 
 # Build the manager binary
-FROM docker.io/library/golang:1.18.6 as builder
+FROM docker.io/library/golang:1.19.2 as builder
 
 # Install FDB this version is only required to compile the fdb operator
 ARG FDB_VERSION=6.2.29

Makefile

@@ -33,7 +33,7 @@ CONTROLLER_GEN_PKG?=sigs.k8s.io/controller-tools/cmd/[email protected]
 CONTROLLER_GEN=$(GOBIN)/controller-gen
 KUSTOMIZE_PKG?=sigs.k8s.io/kustomize/kustomize/[email protected]
 KUSTOMIZE=$(GOBIN)/kustomize
-GOLANGCI_LINT_PKG=github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46.2
+GOLANGCI_LINT_PKG=github.com/golangci/golangci-lint/cmd/golangci-lint@v1.50.1
 GOLANGCI_LINT=$(GOBIN)/golangci-lint
 GORELEASER_PKG=github.com/goreleaser/[email protected]
 GORELEASER=$(GOBIN)/goreleaser

api/v1beta1/foundationdb_database_configuration.go

@@ -335,7 +335,6 @@ func (configuration DatabaseConfiguration) GetNextConfigurationChange(finalConfi
 								} else if dataCenter.Priority > 0 {
 									hasAlternativePrimary = true
 								}
-
 							}
 						}
 					}

api/v1beta1/foundationdbcluster_types.go

@@ -789,7 +789,6 @@ func (clusterStatus FoundationDBClusterStatus) ProcessGroupsByProcessClass(proce
 		if groupStatus.ProcessClass == processClass {
 			result = append(result, groupStatus)
 		}
-
 	}
 
 	return result

api/v1beta2/foundationdb_database_configuration.go

@@ -444,7 +444,6 @@ func (configuration DatabaseConfiguration) GetNextConfigurationChange(finalConfi
 								} else if dataCenter.Priority > 0 {
 									hasAlternativePrimary = true
 								}
-
 							}
 						}
 					}

api/v1beta2/foundationdbcluster_types.go

@@ -620,7 +620,6 @@ func (clusterStatus FoundationDBClusterStatus) ProcessGroupsByProcessClass(proce
 		if groupStatus.ProcessClass == processClass {
 			result = append(result, groupStatus)
 		}
-
 	}
 
 	return result

cmd/po-docgen/api.go

@@ -124,7 +124,6 @@ func ParseDocumentationFrom(srcs []string) []KubeTypes {
 		pkg := astFrom(src)
 
 		for _, kubType := range pkg.Types {
-
 			if structType, ok := kubType.Decl.Specs[0].(*ast.TypeSpec).Type.(*ast.StructType); ok {
 				var ks KubeTypes
 				ks = append(ks, Pair{kubType.Name, fmtRawDoc(kubType.Doc), "", false})

controllers/admin_client_mock.go

@@ -256,7 +256,6 @@ func (client *mockAdminClient) GetStatus() (*fdbv1beta2.FoundationDBStatus, erro
 				Version:       client.Cluster.Status.RunningVersion,
 				UptimeSeconds: uptimeSeconds,
 			}
-
 		}
 	}
 

controllers/change_coordinators.go

@@ -154,7 +154,7 @@ func selectCoordinators(cluster *fdbv1beta2.FoundationDBCluster, status *fdbv1be
 
 	candidates, err := selectCandidates(cluster, status)
 	if err != nil {
-		return []localityInfo{}, nil
+		return []localityInfo{}, err
 	}
 
 	coordinators, err := chooseDistributedProcesses(cluster, candidates, coordinatorCount, processSelectionConstraint{

controllers/cluster_controller.go

@@ -89,7 +89,6 @@ func (r *FoundationDBClusterReconciler) Reconcile(ctx context.Context, request c
 	if err != nil {
 		if k8serrors.IsNotFound(err) {
 			return ctrl.Result{}, nil
-
 		}
 		// Error reading the object - requeue the request.
 		return ctrl.Result{}, err

controllers/update_status.go

@@ -341,7 +341,7 @@ func tryConnectionOptions(cluster *fdbv1beta2.FoundationDBCluster, r *Foundation
 			if err == nil {
 				logger.Info("Chose connection option",
 					"version", version, "connectionString", activeConnectionString)
-				return version, activeConnectionString, err
+				return version, activeConnectionString, nil
 			}
 			logger.Error(err, "Error getting connection string from cluster",
 				"version", version, "connectionString", connectionString)

go.mod

@@ -1,6 +1,6 @@
 module github.com/FoundationDB/fdb-kubernetes-operator
 
-go 1.18
+go 1.19
 
 require (
 	github.com/apple/foundationdb/bindings/go v0.0.0-20201222225940-f3aef311ccfb

internal/deprecations.go

@@ -25,7 +25,6 @@ import (
 
 	fdbtypes "github.com/FoundationDB/fdb-kubernetes-operator/api/v1beta2"
 	corev1 "k8s.io/api/core/v1"
-	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 )
 
@@ -61,12 +60,12 @@ func NormalizeClusterSpec(cluster *fdbtypes.FoundationDBCluster, options Depreca
 
 	if !options.OnlyShowChanges {
 		// Set up resource requirements for the main container.
-		updatePodTemplates(&cluster.Spec, func(template *v1.PodTemplateSpec) {
+		updatePodTemplates(&cluster.Spec, func(template *corev1.PodTemplateSpec) {
 			template.Spec.Containers, _ = ensureContainerPresent(template.Spec.Containers, "foundationdb", 0)
 
-			template.Spec.Containers = customizeContainerFromList(template.Spec.Containers, "foundationdb", func(container *v1.Container) {
+			template.Spec.Containers = customizeContainerFromList(template.Spec.Containers, "foundationdb", func(container *corev1.Container) {
 				if container.Resources.Requests == nil {
-					container.Resources.Requests = v1.ResourceList{
+					container.Resources.Requests = corev1.ResourceList{
 						"cpu":    resource.MustParse("1"),
 						"memory": resource.MustParse("1Gi"),
 					}
@@ -77,9 +76,9 @@ func NormalizeClusterSpec(cluster *fdbtypes.FoundationDBCluster, options Depreca
 				}
 			})
 
-			sidecarUpdater := func(container *v1.Container) {
+			sidecarUpdater := func(container *corev1.Container) {
 				if container.Resources.Requests == nil {
-					container.Resources.Requests = v1.ResourceList{
+					container.Resources.Requests = corev1.ResourceList{
 						"cpu":    resource.MustParse("100m"),
 						"memory": resource.MustParse("256Mi"),
 					}

internal/pod_client.go

@@ -173,7 +173,6 @@ func (client *realFdbPodSidecarClient) getListenIP() string {
 
 // makeRequest submits a request to the sidecar.
 func (client *realFdbPodSidecarClient) makeRequest(method, path string) (string, int, error) {
-	var resp *http.Response
 	var err error
 
 	protocol := "http"
@@ -190,13 +189,16 @@ func (client *realFdbPodSidecarClient) makeRequest(method, path string) (string,
 	}
 
 	url := fmt.Sprintf("%s://%s:8080/%s", protocol, client.getListenIP(), path)
+	var resp *http.Response
 	switch method {
 	case http.MethodGet:
 		retryClient.HTTPClient.Timeout = client.getTimeout
 		resp, err = retryClient.Get(url)
+		defer resp.Body.Close()
 	case http.MethodPost:
 		retryClient.HTTPClient.Timeout = client.postTimeout
 		resp, err = retryClient.Post(url, "application/json", strings.NewReader(""))
+		defer resp.Body.Close()
 	default:
 		return "", 0, fmt.Errorf("unknown HTTP method %s", method)
 	}
@@ -205,8 +207,6 @@ func (client *realFdbPodSidecarClient) makeRequest(method, path string) (string,
 		return "", 0, err
 	}
 
-	defer resp.Body.Close()
-
 	body, err := io.ReadAll(resp.Body)
 	bodyText := string(body)
 
@@ -221,7 +221,7 @@ func (client *realFdbPodSidecarClient) makeRequest(method, path string) (string,
 func (client *realFdbPodSidecarClient) IsPresent(filename string) (bool, error) {
 	version, err := fdbv1beta2.ParseFdbVersion(client.Cluster.Spec.Version)
 	if err != nil {
-		return false, nil
+		return false, err
 	}
 
 	path := "check_hash"

internal/pod_models.go

@@ -852,7 +852,6 @@ func GetBackupDeployment(backup *fdbv1beta2.FoundationDBBackup) (*appsv1.Deploym
 		for _, customParameter := range backup.Spec.CustomParameters {
 			args = append(args, fmt.Sprintf("--%s", customParameter))
 		}
-
 	}
 
 	mainContainer.Args = args

kubectl-fdb/cmd/analyze_test.go

@@ -79,7 +79,6 @@ func getPodList(clusterName string, namespace string, status corev1.PodStatus, d
 			},
 		},
 	}
-
 }
 
 var _ = Describe("[plugin] analyze cluster", func() {

kubectl-fdb/cmd/exec.go

@@ -111,14 +111,14 @@ func buildCommand(kubeClient client.Client, cluster *fdbv1beta2.FoundationDBClus
 	for key, value := range cluster.GetMatchLabels() {
 		requirement, err := labels.NewRequirement(key, selection.Equals, []string{value})
 		if err != nil {
-			return exec.Cmd{}, nil
+			return exec.Cmd{}, err
 		}
 		selector = selector.Add(*requirement)
 	}
 
 	processClassRequirement, err := labels.NewRequirement(cluster.GetProcessClassLabel(), selection.Exists, nil)
 	if err != nil {
-		return exec.Cmd{}, nil
+		return exec.Cmd{}, err
 	}
 	selector = selector.Add(*processClassRequirement)
 

kubectl-fdb/cmd/k8s_client.go

@@ -37,7 +37,6 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/kubernetes"
-	"k8s.io/client-go/kubernetes/scheme"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/clientcmd"
 	"k8s.io/client-go/tools/remotecommand"
@@ -143,7 +142,7 @@ func executeCmd(restConfig *rest.Config, kubeClient *kubernetes.Clientset, podNa
 	}
 	req.VersionedParams(
 		option,
-		scheme.ParameterCodec,
+		clientgoscheme.ParameterCodec,
 	)
 	exec, err := remotecommand.NewSPDYExecutor(restConfig, "POST", req.URL())
 	if err != nil {

kubectl-fdb/cmd/version.go

@@ -47,11 +47,11 @@ func newVersionCmd(streams genericclioptions.IOStreams) *cobra.Command {
 			}
 			clientOnly, err := cmd.Flags().GetBool("client-only")
 			if err != nil {
-				return nil
+				return err
 			}
 			containerName, err := cmd.Flags().GetString("container-name")
 			if err != nil {
-				return nil
+				return err
 			}
 
 			if !clientOnly {