Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A nan_policy kwarg for the sample estimators #70

Open
jorenham opened this issue Nov 4, 2023 · 0 comments
Open

A nan_policy kwarg for the sample estimators #70

jorenham opened this issue Nov 4, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
v1.0.0

Comments

@jorenham
Copy link
Owner

jorenham commented Nov 4, 2023

Currently, data with nan's are either always propagated, or an error is raised (e.g. np.asarray_chkfinite raises a ValueError).
The behaviour around nan's is currently unspecified and untested.

Luckily, SciPy has their very well-specified nan_policy (https://scipy.github.io/devdocs/dev/api-dev/nan_policy.html) which appears to be very much applicable to (at least) Lmo's sample estimators.
@jorenham jorenham added the enhancement New feature or request label Nov 4, 2023
@jorenham jorenham changed the title nan_policy: 'omit' | 'raise' | 'propagate' A nan_policy kwarg for the sample estimators Nov 4, 2023
@jorenham jorenham added this to the v1.0.0 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@jorenham