Fixes microsoft#1465 - Remove use of logger and replace with direct calls to console. (microsoft#1606)

Author: tracyboehrer

samples/javascript_nodejs/05.multi-turn-prompt/bots/dialogBot.js

@@ -9,26 +9,20 @@ class DialogBot extends ActivityHandler {
      * @param {ConversationState} conversationState
      * @param {UserState} userState
      * @param {Dialog} dialog
-     * @param {any} logger object for logging events, defaults to console if none is provided
      */
-    constructor(conversationState, userState, dialog, logger) {
+    constructor(conversationState, userState, dialog) {
         super();
         if (!conversationState) throw new Error('[DialogBot]: Missing parameter. conversationState is required');
         if (!userState) throw new Error('[DialogBot]: Missing parameter. userState is required');
         if (!dialog) throw new Error('[DialogBot]: Missing parameter. dialog is required');
-        if (!logger) {
-            logger = console;
-            logger.log('[DialogBot]: logger not passed in, defaulting to console');
-        }
 
         this.conversationState = conversationState;
         this.userState = userState;
         this.dialog = dialog;
-        this.logger = logger;
         this.dialogState = this.conversationState.createProperty('DialogState');
 
         this.onMessage(async (context, next) => {
-            this.logger.log('Running dialog with Message Activity.');
+            console.log('Running dialog with Message Activity.');
 
             // Run the Dialog with the new message Activity.
             await this.dialog.run(context, this.dialogState);

samples/javascript_nodejs/05.multi-turn-prompt/dialogs/userProfileDialog.js

@@ -22,13 +22,11 @@ const USER_PROFILE = 'USER_PROFILE';
 const WATERFALL_DIALOG = 'WATERFALL_DIALOG';
 
 class UserProfileDialog extends ComponentDialog {
-    constructor(userState, logger) {
+    constructor(userState) {
         super('userProfileDialog');
 
         this.userProfile = userState.createProperty(USER_PROFILE);
 
-        this.logger = logger;
-
         this.addDialog(new TextPrompt(NAME_PROMPT));
         this.addDialog(new ChoicePrompt(CHOICE_PROMPT));
         this.addDialog(new ConfirmPrompt(CONFIRM_PROMPT));

samples/javascript_nodejs/05.multi-turn-prompt/index.js

@@ -41,12 +41,9 @@ const memoryStorage = new MemoryStorage();
 const conversationState = new ConversationState(memoryStorage);
 const userState = new UserState(memoryStorage);
 
-// Pass in a logger to the bot. For this sample, the logger is the console, but alternatives such as Application Insights and Event Hub exist for storing the logs of the bot.
-const logger = console;
-
 // Create the main dialog.
-const dialog = new UserProfileDialog(userState, logger);
-const bot = new DialogBot(conversationState, userState, dialog, logger);
+const dialog = new UserProfileDialog(userState);
+const bot = new DialogBot(conversationState, userState, dialog);
 
 // Create HTTP server.
 let server = restify.createServer();

samples/javascript_nodejs/06.using-cards/bots/dialogBot.js

@@ -16,26 +16,20 @@ class DialogBot extends ActivityHandler {
      * @param {ConversationState} conversationState
      * @param {UserState} userState
      * @param {Dialog} dialog
-     * @param {any} logger object for logging events, defaults to console if none is provided
      */
-    constructor(conversationState, userState, dialog, logger) {
+    constructor(conversationState, userState, dialog) {
         super();
         if (!conversationState) throw new Error('[DialogBot]: Missing parameter. conversationState is required');
         if (!userState) throw new Error('[DialogBot]: Missing parameter. userState is required');
         if (!dialog) throw new Error('[DialogBot]: Missing parameter. dialog is required');
-        if (!logger) {
-            logger = console;
-            logger.log('[DialogBot]: logger not passed in, defaulting to console');
-        }
 
         this.conversationState = conversationState;
         this.userState = userState;
         this.dialog = dialog;
-        this.logger = logger;
         this.dialogState = this.conversationState.createProperty('DialogState');
 
         this.onMessage(async (context, next) => {
-            this.logger.log('Running dialog with Message Activity.');
+            console.log('Running dialog with Message Activity.');
 
             // Run the Dialog with the new message Activity.
             await this.dialog.run(context, this.dialogState);

samples/javascript_nodejs/06.using-cards/bots/richCardsBot.js

@@ -9,8 +9,8 @@ const { DialogBot } = require('./dialogBot');
  * that matches the user's selection.
  */
 class RichCardsBot extends DialogBot {
-    constructor(conversationState, userState, dialog, logger) {
-        super(conversationState, userState, dialog, logger);
+    constructor(conversationState, userState, dialog) {
+        super(conversationState, userState, dialog);
 
         this.onMembersAdded(async (context, next) => {
             const membersAdded = context.activity.membersAdded;

samples/javascript_nodejs/06.using-cards/dialogs/mainDialog.js

@@ -8,16 +8,9 @@ const AdaptiveCard = require('../resources/adaptiveCard.json');
 const MAIN_WATERFALL_DIALOG = 'mainWaterfallDialog';
 
 class MainDialog extends ComponentDialog {
-    constructor(logger) {
+    constructor() {
         super('MainDialog');
 
-        if (!logger) {
-            logger = console;
-            logger.log('[MainDialog]: logger not passed in, defaulting to console');
-        }
-
-        this.logger = logger;
-
         // Define the main dialog and its related components.
         this.addDialog(new ChoicePrompt('cardPrompt'));
         this.addDialog(new WaterfallDialog(MAIN_WATERFALL_DIALOG, [
@@ -53,7 +46,7 @@ class MainDialog extends ComponentDialog {
      * @param {WaterfallStepContext} stepContext
      */
     async choiceCardStep(stepContext) {
-        this.logger.log('MainDialog.choiceCardStep');
+        console.log('MainDialog.choiceCardStep');
 
         // Create the PromptOptions which contain the prompt and re-prompt messages.
         // PromptOptions also contains the list of choices available to the user.
@@ -73,7 +66,7 @@ class MainDialog extends ComponentDialog {
      * @param {WaterfallStepContext} stepContext
      */
     async showCardStep(stepContext) {
-        this.logger.log('MainDialog.showCardStep');
+        console.log('MainDialog.showCardStep');
 
         switch (stepContext.result.value) {
         case 'Adaptive Card':

samples/javascript_nodejs/06.using-cards/index.js

@@ -46,12 +46,9 @@ const memoryStorage = new MemoryStorage();
 conversationState = new ConversationState(memoryStorage);
 userState = new UserState(memoryStorage);
 
-// Pass in a logger to the bot. For this sample, the logger is the console, but alternatives such as Application Insights and Event Hub exist for storing the logs of the bot.
-const logger = console;
-
 // Create the main dialog.
-const dialog = new MainDialog(logger);
-const bot = new RichCardsBot(conversationState, userState, dialog, logger);
+const dialog = new MainDialog();
+const bot = new RichCardsBot(conversationState, userState, dialog);
 
 // Create HTTP server.
 let server = restify.createServer();

samples/javascript_nodejs/11.qnamaker/bots/QnABot.js

@@ -5,15 +5,8 @@ const { ActivityHandler } = require('botbuilder');
 const { QnAMaker } = require('botbuilder-ai');
 
 class QnABot extends ActivityHandler {
-    /**
-     * @param {any} logger object for logging events, defaults to console if none is provided
-     */
-    constructor(logger) {
+    constructor() {
         super();
-        if (!logger) {
-            logger = console;
-            logger.log('[QnaMakerBot]: logger not passed in, defaulting to console');
-        }
 
         try {
             this.qnaMaker = new QnAMaker({
@@ -22,9 +15,8 @@ class QnABot extends ActivityHandler {
                 host: process.env.QnAEndpointHostName
             });
         } catch (err) {
-            logger.warn(`QnAMaker Exception: ${ err } Check your QnAMaker configuration in .env`);
+            console.warn(`QnAMaker Exception: ${ err } Check your QnAMaker configuration in .env`);
         }
-        this.logger = logger;
 
         // If a new user is added to the conversation, send them a greeting message
         this.onMembersAdded(async (context, next) => {
@@ -41,7 +33,7 @@ class QnABot extends ActivityHandler {
 
         // When a user sends a message, perform a call to the QnA Maker service to retrieve matching Question and Answer pairs.
         this.onMessage(async (context, next) => {
-            this.logger.log('Calling QnA Maker');
+            console.log('Calling QnA Maker');
 
             const qnaResults = await this.qnaMaker.getAnswers(context);
 

samples/javascript_nodejs/11.qnamaker/index.js

@@ -34,11 +34,8 @@ adapter.onTurnError = async (context, error) => {
     await context.sendActivity(`Oops. Something went wrong!`);
 };
 
-// Pass in a logger to the bot. For this sample, the logger is the console, but alternatives such as Application Insights and Event Hub exist for storing the logs of the bot.
-const logger = console;
-
 // Create the main dialog.
-const bot = new QnABot(logger);
+const bot = new QnABot();
 
 // Create HTTP server
 let server = restify.createServer();

samples/javascript_nodejs/13.core-bot/bots/dialogAndWelcomeBot.js

@@ -6,8 +6,8 @@ const { DialogBot } = require('./dialogBot');
 const WelcomeCard = require('./resources/welcomeCard.json');
 
 class DialogAndWelcomeBot extends DialogBot {
-    constructor(conversationState, userState, dialog, logger) {
-        super(conversationState, userState, dialog, logger);
+    constructor(conversationState, userState, dialog) {
+        super(conversationState, userState, dialog);
 
         this.onMembersAdded(async (context, next) => {
             const membersAdded = context.activity.membersAdded;