-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain date ranges may start after they end #78
Comments
@mullwaden I can certainly see your point of view, and appreciate that you have proposed a fix. I think this change makes sense - I'm including a table of how I would expect parsing to change with this, in case you, or anyone else wants to work on a PR. I could eventually get to this myself, but have less time right now, so it might be a while.
Side note: I wouldn't mind refactoring a lot of the date-related code; it could use some improvement in general. |
something like this maybe? |
A profile might, on a work experience for example, have a date range that is "2007 - oct 2007". The this fix will interpret that as "2007-12-31 - 2007-10-31".
Start ends up bigger than end. I would suggest the fix is the following:
Maybe this will break a lot of things for people... Otherwise I am happy to make a PR.
The text was updated successfully, but these errors were encountered: