From d97c5a914cc576f20007e68df60ca556b0c4dc4c Mon Sep 17 00:00:00 2001 From: Ben Morgan Date: Tue, 16 Jul 2024 09:36:12 +0100 Subject: [PATCH 1/2] Remove logically dead code --- source/UserTaskQueue.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/source/UserTaskQueue.cc b/source/UserTaskQueue.cc index d0af18e..3ab8078 100644 --- a/source/UserTaskQueue.cc +++ b/source/UserTaskQueue.cc @@ -296,7 +296,6 @@ UserTaskQueue::InsertTask(task_pointer&& task, ThreadData* data, intmax_t subq) if(insert_task(_n)) return _n; } - return GetThreadBin(); } //======================================================================================// From c209b925ddb986884c0be894fe8ef73bf0c1b5ed Mon Sep 17 00:00:00 2001 From: Ben Morgan Date: Tue, 16 Jul 2024 09:39:14 +0100 Subject: [PATCH 2/2] Avoid unneeded copy with explicit move --- source/Threading.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/Threading.cc b/source/Threading.cc index 2b4d31f..49f52b4 100644 --- a/source/Threading.cc +++ b/source/Threading.cc @@ -103,7 +103,7 @@ GetNumberOfPhysicalCpus() while((_pos = line.find(itr)) != _npos) line = line.replace(_pos, itr.length(), ""); } - core_ids.insert(line); + core_ids.insert(std::move(line)); } } core_id_count = static_cast(core_ids.size());