-
Notifications
You must be signed in to change notification settings - Fork 34
Compiling assets is picking up a warning #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Interesting, but looks more like a sprockets bug, this is what we do to compile the assets: https://github.com/jruby/heroku-buildpack-jruby/blob/master/bin/compile#L174 |
btw, are you using the the default heroku buildpack or this buildpack? this line made me wonder: https://github.com/softwaregravy/aws_info/blob/master/Gemfile#L3 |
I assumed I was. I followed: https://devcenter.heroku.com/articles/moving-an-existing-rails-app-to-run-on-jruby#specify-jruby-in-your-gemfile which is where that line in my Gemfile came from |
ok, then you're not, you can report the bug to https://github.com/heroku/heroku-buildpack-ruby and/or try the same app but with this buildpack:
you can switch back at any time with:
|
Thanks for the help |
FYI. This doesn't look like a problem specific to this project, but I can't use this buildback because:
|
yeah, git repos in the gem file isn't working.. On Monday 29 April 2013 at 11:54, John Hinnegan wrote:
|
This looks like its an issues with the closure_compiler - documentcloud/closure-compiler#23 (comment) however removing: config.assets.js_compressor = :closure as recommended did not help and then caused issues with bootstrap:
It also seem that he build pack does not always compile the assets on a push...why would that be ? Manually compiling does not solve the problem,so not directly a problem. |
Notice the first line? This was compiled on heroku.
I then precompiled the assets and pushed which fixed it. I should be able to just push and have it precompile on the heroku side though, no?
Thoughts? app is here https://github.com/softwaregravy/aws_info
The text was updated successfully, but these errors were encountered: