Skip to content

Commit f3aa8e4

Browse files
jim-vljim-acb
authored andcommitted
refactor: renamed datetime mocks for clarity
1 parent ca89a94 commit f3aa8e4

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

tests/test_azure.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ def test_url_expire(self, generate_blob_sas_mocked):
159159
datetime.datetime(2016, 11, 6, 4), datetime.timezone.utc
160160
)
161161

162-
with mock.patch("storages.backends.azure_storage.datetime") as d_mocked:
162+
with mock.patch("storages.backends.azure_storage.datetime") as datetime_mocked:
163163
# Implicit read permission
164-
d_mocked.utcnow.return_value = fixed_time
164+
datetime_mocked.utcnow.return_value = fixed_time
165165
self.assertEqual(
166166
self.storage.url("some blob", 100),
167167
"https://ret_foo.blob.core.windows.net/test/some%20blob",
@@ -179,7 +179,7 @@ def test_url_expire(self, generate_blob_sas_mocked):
179179
self.assertEqual(str(called_kwargs["permission"]), "r")
180180

181181
# Explicit write permission
182-
d_mocked.utcnow.return_value = fixed_time
182+
datetime_mocked.utcnow.return_value = fixed_time
183183
self.assertEqual(
184184
self.storage.url("some blob", expire=100, mode="w"),
185185
"https://ret_foo.blob.core.windows.net/test/some%20blob",
@@ -218,8 +218,8 @@ def test_url_expire_user_delegation_key(self, generate_blob_sas_mocked):
218218
fixed_time = make_aware(
219219
datetime.datetime(2016, 11, 6, 4), datetime.timezone.utc
220220
)
221-
with mock.patch("storages.backends.azure_storage.datetime") as d_mocked:
222-
d_mocked.utcnow.return_value = fixed_time
221+
with mock.patch("storages.backends.azure_storage.datetime") as datetime_mocked:
222+
datetime_mocked.utcnow.return_value = fixed_time
223223
service_client.get_user_delegation_key.return_value = "user delegation key"
224224
self.assertEqual(
225225
self.storage.url("some blob", 100),

tests/test_s3.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,7 @@ def test_url_protocol(self):
728728
self.assertEqual(storage.url_protocol, "https:")
729729

730730
@mock.patch("storages.backends.s3.datetime")
731-
def test_storage_url_custom_domain_signed_urls(self, dt):
731+
def test_storage_url_custom_domain_signed_urls(self, dt_mocked):
732732
key_id = "test-key"
733733
filename = "file.txt"
734734
pem = dedent(
@@ -766,7 +766,7 @@ def test_storage_url_custom_domain_signed_urls(self, dt):
766766
self.assertEqual(self.storage.url(filename), url)
767767

768768
self.storage.querystring_auth = True
769-
dt.utcnow.return_value = datetime.datetime.utcfromtimestamp(0)
769+
dt_mocked.utcnow.return_value = datetime.datetime.utcfromtimestamp(0)
770770
self.assertEqual(self.storage.url(filename), signed_url)
771771

772772
def test_generated_url_is_encoded(self):

0 commit comments

Comments
 (0)