You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently our unit tests update static files in the /data folder (cloud ip ranges, malware domains/ips, geonames) and leaves them in that state after. That brings inconsistency to dev env, for example if geo location of a dev probe is not specified in the test mock file after the test run it will be unresolvable during development. I specified current dev geo ips in that file, but that is not stable.
One of that should be done:
use mock-fs for all tests instead of updating real files;
revert files to it's prev state after the tests;
use same files in tests as in dev/prod (in theory may be inconsistent as files might change);
The text was updated successfully, but these errors were encountered:
Currently our unit tests update static files in the /data folder (cloud ip ranges, malware domains/ips, geonames) and leaves them in that state after. That brings inconsistency to dev env, for example if geo location of a dev probe is not specified in the test mock file after the test run it will be unresolvable during development. I specified current dev geo ips in that file, but that is not stable.
One of that should be done:
The text was updated successfully, but these errors were encountered: