Add review-diff command and remove production-readiness feature by jsegov · Pull Request #4 · jsegov/shipspec-claude-code-plugin

jsegov · 2026-01-11T21:02:29Z

Summary

Adds /review-diff <feature-name> command that validates implementation work against planning artifacts
Removes /production-readiness-review command and all related components to simplify the plugin
Focuses the plugin exclusively on feature planning workflow

Changes

Added: /review-diff command

Validates implementation against planning artifacts:

Acceptance Criteria - All criteria from the task in TASKS.md are met
Design Alignment - Implementation follows the referenced SDD section
Requirements Coverage - Referenced PRD requirements are satisfied

Removed: /production-readiness-review

Removed to simplify the plugin scope:

commands/production-readiness-review.md
agents/production-analyzer.md
agents/production-interviewer.md
agents/production-reporter.md
skills/production-analysis/SKILL.md
skills/production-signals/SKILL.md

Bug Fixes

Fix git diff --stat to capture both staged and unstaged changes (git diff HEAD --stat)
Add BLOCKED state handling for design/requirements validation in verdict logic

Workflow

/feature-planning my-feature       # Plan the feature
        ↓
/implement-next-task my-feature    # Start a task (marks it [~])
        ↓
   Implement the task              # Write the code
        ↓
/review-diff my-feature            # Validate against PRD, SDD, acceptance criteria
        ↓
   Passed? → Task marked [x], suggests next task
   Failed? → Shows issues to fix, re-run after fixing

Test plan

Run /feature-planning test-feature to create planning artifacts
Run /implement-next-task test-feature to start a task
Make code changes (stage some with git add)
Run /review-diff test-feature to validate
Verify task is marked [x] on success
Verify removed commands/agents/skills are no longer available

🤖 Generated with Claude Code

Adds /review-diff command that validates implementation work against planning artifacts after completing a task from /implement-next-task. Features: - Validates acceptance criteria from TASKS.md - Checks design alignment with referenced SDD section - Verifies requirements coverage from PRD.md - Auto-completes task [x] if all validations pass - Uses git diff to detect changed files - Supports both feature planning and production readiness workflows Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

linear · 2026-01-11T21:02:32Z

SHI-31 review-diff command

focus on diff but should take entire codebase into account

claude · 2026-01-11T21:05:47Z

No issues found. Checked for bugs and CLAUDE.md compliance.

commands/review-diff.md

- Add explicit overlap handling for mixed workflow artifacts inline with detection logic (both files) - Remove redundant Edge Cases sections now that priority rules are documented at point of use - Add BLOCKED verdict for tasks missing acceptance criteria in review-diff to prevent vacuous auto-approval - Make design alignment and requirements coverage steps workflow-aware in review-diff (skip for Production Readiness workflow) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

commands/review-diff.md

- Change production-readiness-review output from .shipspec/planning/ to .shipspec/production-readiness/ - Add auto-detect logic to implement-next-task and review-diff to check both directories and determine workflow type by location - Add cleanup of intermediate production-signals.md file - Update README with new directory structure and command references Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

commands/production-readiness-review.md

commands/implement-next-task.md

Step 5.5 uses `rm -f` to clean up intermediate production-signals.md file, but allowed-tools header was missing Bash(rm:*) permission. This caused the cleanup step to fail or require manual permission. Matches the pattern already used in feature-planning.md for context.md cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

commands/review-diff.md

The success message now correctly indicates that Design Alignment and Requirements validations may be N/A for Production Readiness workflows, matching the summary table format in Step 8. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

commands/review-diff.md

Add handling for when task references exist but target content is missing: - Step 6: If referenced SDD section not found, show warning and mark BLOCKED - Step 7: If referenced PRD requirements not found, show warning and mark CANNOT_VERIFY (partial) or BLOCKED (all missing) Previously only handled "no reference in task" but not "reference exists, target missing" which could cause undefined behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

commands/review-diff.md

- Remove /production-readiness-review command and related components: - agents/production-analyzer.md - agents/production-interviewer.md - agents/production-reporter.md - skills/production-analysis/SKILL.md - skills/production-signals/SKILL.md - Fix review-diff.md bugs: - Use `git diff HEAD --stat` to capture both staged and unstaged changes - Add BLOCKED state handling for design/requirements validation in verdict logic - Simplify implement-next-task.md to only support feature planning workflow - Update README to reflect simplified plugin (feature planning only) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>