Skip to content

Commit dfe7a8c

Browse files
committed
Set alt attribute for images (content configurable through the data-lity-desc attribute)
1 parent 7a8e4c5 commit dfe7a8c

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

dist/lity.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,9 @@
120120
return $('<span class="lity-error"/>').append(msg);
121121
}
122122

123-
function imageHandler(target) {
124-
var img = $('<img src="' + target + '"/>');
123+
function imageHandler(target, instance) {
124+
var desc = (instance.opener() && instance.opener().data('lity-desc')) || 'Image with no description';
125+
var img = $('<img src="' + target + '" alt="' + desc + '"/>');
125126
var deferred = _deferred();
126127
var failed = function() {
127128
deferred.reject(error('Failed loading image'));

dist/lity.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ <h2>Lightweight, accessible and responsive lightbox.</h2>
4747
<h3>Demos</h3>
4848

4949
<p>
50-
<a class="btn" href="https://farm9.staticflickr.com/8642/16455005578_0fdfc6c3da_b.jpg" data-lity>Image</a>
50+
<a class="btn" href="https://farm9.staticflickr.com/8642/16455005578_0fdfc6c3da_b.jpg" data-lity data-lity-desc="Photo of a flower">Image</a>
5151
<a class="btn" href="#inline" data-lity>Inline</a>
5252
<a class="btn" href="//maps.google.com/maps?q=1600+Amphitheatre+Parkway,+Mountain+View,+CA" data-lity>Google Maps</a>
5353
<a class="btn" href="//www.youtube.com/watch?v=XSGBVzeBUbk" data-lity>YouTube</a>
@@ -98,7 +98,7 @@ <h4>Declarative</h4>
9898
<p>Add the <code>data-lity</code> attribute to <code>&lt;a></code> elements for which you want the links to
9999
be opened in a lightbox:</p>
100100

101-
<pre><code class="language-markup">&lt;a href="https://farm9.staticflickr.com/8642/16455005578_0fdfc6c3da_b.jpg" data-lity>Image&lt;/a>
101+
<pre><code class="language-markup">&lt;a href="https://farm9.staticflickr.com/8642/16455005578_0fdfc6c3da_b.jpg" data-lity data-lity-desc="Photo of a flower">Image&lt;/a>
102102
&lt;a href="#inline" data-lity>Inline&lt;/a>
103103
&lt;a href="//www.youtube.com/watch?v=XSGBVzeBUbk" data-lity>iFrame Youtube&lt;/a>
104104
&lt;a href="//vimeo.com/1084537" data-lity>iFrame Vimeo&lt;/a>

src/lity.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,9 @@
117117
return $('<span class="lity-error"/>').append(msg);
118118
}
119119

120-
function imageHandler(target) {
121-
var img = $('<img src="' + target + '"/>');
120+
function imageHandler(target, instance) {
121+
var desc = (instance.opener() && instance.opener().data('lity-desc')) || 'Image with no description';
122+
var img = $('<img src="' + target + '" alt="' + desc + '"/>');
122123
var deferred = _deferred();
123124
var failed = function() {
124125
deferred.reject(error('Failed loading image'));

0 commit comments

Comments
 (0)