Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print all publishing files in jsr publish #979

Open
ai opened this issue Feb 22, 2025 · 1 comment
Open

Print all publishing files in jsr publish #979

ai opened this issue Feb 22, 2025 · 1 comment
Labels
publishing Problems with publishing

Comments

@ai
Copy link

ai commented Feb 22, 2025

I try to reduce unnecessary files in node_modules for performance and minimalism reasons.

Right now, during publishing step there is no way to check what files I am going to publish. In contrast, when I do npm publish I see the list:

$ npm publish                      
npm notice 📦  [email protected]
npm notice Tarball Contents
npm notice 1.1kB LICENSE
npm notice 14.3kB README.md
npm notice 1.1kB bin/nanoid.js
npm notice 332B eslint.config.js
npm notice 2.6kB index.browser.js
npm notice 2.5kB index.d.ts
npm notice 3.4kB index.js
npm notice 197B nanoid.js
npm notice 983B non-secure/index.d.ts
npm notice 1.1kB non-secure/index.js
npm notice 2.9kB package.json
npm notice 255B url-alphabet/index.js
npm notice Tarball Details
npm notice name: nanoid
npm notice version: 5.1.0
npm notice filename: nanoid-5.1.0.tgz
npm notice package size: 27.0 kB
npm notice unpacked size: 89.2 kB

I think adding this output to jsr publish is good because:

  1. It allows debugging publish.include before really publishing package.
  2. It will remind developers that they are publishing dev configs to the registry (and using resources of users).
  3. It may remind of forgotten file when you added a file, but forgot to add it to publish.include.
@github-project-automation github-project-automation bot moved this to Needs Triage in JSR Feb 22, 2025
@AugustinMauroy
Copy link
Contributor

hey

when you do npx jsr --dry-run it's show me all included files.
But yes on simple publish I don't. It's an issue on deno (JSR CLI is a wrapper of deno CLI)

@lucacasonato where should I report it for deno side ?

@crowlKats crowlKats added the publishing Problems with publishing label Mar 12, 2025
@crowlKats crowlKats moved this from Needs Triage to Ready in JSR Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publishing Problems with publishing
Projects
Status: Ready
Development

No branches or pull requests

3 participants