Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing a solution for non-declared typings dependencies #989

Open
panva opened this issue Feb 24, 2025 · 0 comments
Open

missing a solution for non-declared typings dependencies #989

panva opened this issue Feb 24, 2025 · 0 comments

Comments

@panva
Copy link

panva commented Feb 24, 2025

I've just published https://jsr.io/@panva/openid-client and I had to forego publishing one of its entrypoints, namely its passport strategy implementation.

The problem i encountered is that express and passport from which only types are imported cannot be resolved. I am not keen on adding these modules as dependency in jsr.json because not all users use the passport strategy and those who do (and care about types) must have their respective types installed already, and for those who don't care about passport (large amount of users) I don't wish to incur the dependency.

The original failed publish details https://jsr.io/status/e496c2cf-23ea-4d34-b08d-0488cff185b5, it is important to note that this failed on the server but locally npx jsr publish --dry-run did not fail, which made hopeful this wouldn't happen.

The ask: how should this be dealt with? This module and this entrypoint is happily published and used from npm without these dependencies.

Relates to #978

@github-project-automation github-project-automation bot moved this to Needs Triage in JSR Feb 24, 2025
@panva panva changed the title missing solution for non-declared typings dependencies missing a solution for non-declared typings dependencies Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage
Development

No branches or pull requests

1 participant