Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some empty directories will be leaked after sync #5698

Open
davies opened this issue Feb 26, 2025 · 1 comment
Open

Some empty directories will be leaked after sync #5698

davies opened this issue Feb 26, 2025 · 1 comment
Assignees
Labels
kind/bug Something isn't working

Comments

@davies
Copy link
Contributor

davies commented Feb 26, 2025

sync tries to remove a directory before removing all the children, will fail with ENOTEMPTY and be leaked.

@davies davies added the kind/bug Something isn't working label Feb 26, 2025
@davies
Copy link
Contributor Author

davies commented Feb 26, 2025

We can remove the directories in deep first order in the end of sync

@zhijian-pro zhijian-pro self-assigned this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants