Skip to content

Commit 5458c3e

Browse files
committed
Fix test other.test_browser_language_detection to allow any language (e.g. en_US, en_FI, fi_FI, and so on). This allows developers who are not en_US to also run the test.
1 parent d0aa66d commit 5458c3e

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

test/test_other.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6901,7 +6901,8 @@ def test_browser_language_detection(self):
69016901
# We support both "C" and "en_US" here since older versions of node do
69026902
# not expose navigator.languages.
69036903
lang = os.environ.get('LANG', 'C.UTF-8')
6904-
self.assertContained(f'LANG=({lang}|en_US.UTF-8|C.UTF-8)', self.run_js('a.out.js'), regex=True)
6904+
# User may have their own language set, so match regex ".._.." to catch any language, e.g. en_US, en_FI, etc.
6905+
self.assertContained(f'LANG=({lang}|.._..\\.UTF-8|C.UTF-8)', self.run_js('a.out.js'), regex=True)
69056906

69066907
# Accept-Language: fr,fr-FR;q=0.8,en-US;q=0.5,en;q=0.3
69076908
create_file('pre.js', 'var navigator = { language: "fr" };')

0 commit comments

Comments
 (0)