Skip to content

Commit 90d5b61

Browse files
authored
fix: add missing modals and test ids (#2706)
1 parent 9d7cf0b commit 90d5b61

3 files changed

Lines changed: 18 additions & 5 deletions

File tree

src/app/ui/portfolio/PortfolioPositionsList.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ import { PortfolioAnimatedAssetContainer } from './PortfolioAnimatedAssetContain
1010
import { useMemo } from 'react';
1111
import { hasPositionDataToDisplay } from '@/components/composite/PositionCard/utils';
1212
import { mapValues, pickBy } from 'lodash';
13+
import { DepositFlowModal } from '@/components/composite/DepositFlow/DepositFlow';
14+
import { WithdrawFlowModal } from '@/components/composite/WithdrawFlow/WithdrawFlow';
1315

1416
export const PortfolioPositionsList = () => {
1517
const { data, isEmpty, isLoading, clearFilters } = usePositionsFiltering();
@@ -55,8 +57,12 @@ export const PortfolioPositionsList = () => {
5557
}
5658

5759
return (
58-
<PortfolioAssetsListContainer useFlexGap direction="column">
59-
<AnimatePresence mode="popLayout">{renderContent()}</AnimatePresence>
60-
</PortfolioAssetsListContainer>
60+
<>
61+
<PortfolioAssetsListContainer useFlexGap direction="column">
62+
<AnimatePresence mode="popLayout">{renderContent()}</AnimatePresence>
63+
</PortfolioAssetsListContainer>
64+
<DepositFlowModal />
65+
<WithdrawFlowModal />
66+
</>
6167
);
6268
};

src/components/composite/PositionCard/PositionCard.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,12 @@ export const PositionCard: FC<PositionCardProps> = ({
103103
: [];
104104

105105
return (
106-
<StyledAccordion expanded={isExpanded} disableGutters>
106+
<StyledAccordion
107+
data-testId="position-card"
108+
aria-label={`Position card for ${firstPosition.protocol.name} protocol`}
109+
expanded={isExpanded}
110+
disableGutters
111+
>
107112
<StyledAccordionSummary>
108113
<StyledSummaryContent onClick={() => handleMainPositionClick()}>
109114
<EntityStackWithBadge
@@ -233,7 +238,7 @@ export const PositionCard: FC<PositionCardProps> = ({
233238
</StyledOverviewActions>
234239
</StyledOverviewColumn>
235240

236-
<StyledTablesColumn>
241+
<StyledTablesColumn data-testId="position-card-entry">
237242
{positionGroup.sections.map((section) => (
238243
<ColumnTable
239244
key={section.id}

src/components/composite/PositionCard/utils.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ export const renderPositionActions = ({
178178
protocolUrl={item.protocol.url}
179179
protocolName={item.protocol.name}
180180
disabled={!item.earn}
181+
data-testId="portfolio-withdraw-button"
181182
/>
182183
<DepositFlowOnDemandButton
183184
displayMode={DepositButtonDisplayMode.LabelOnly}
@@ -188,6 +189,7 @@ export const renderPositionActions = ({
188189
protocolUrl={item.protocol.url}
189190
protocolName={item.protocol.name}
190191
disabled={!item.earn}
192+
data-testId="portfolio-deposit-button"
191193
/>
192194
</StyledPositionActions>
193195
);

0 commit comments

Comments
 (0)