-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs for metadata need updating #47
Comments
Specifically, they don't currently mention language_info |
(there may well be other problems too, but that's one omission I've noticed) |
Docs list a "deletable" field, but this isn't implemented. |
I see code in the notebook UI that checks |
But surely it should be in the schema JSON right ? Maybe I'm just misunderstanding the purpose of this repo. |
I don't think the schema includes keys in metadata, because the ones we use don't have to be there, and arbitrary ones we don't use are allowed there. It's essentially a free key-value store, but the docs describe a few fields that Jupyter applications use. |
@takluyver kinda makes sense to me, but also seems to contradict what is in the schema since some metadata fields are included. For instance, for code cells "scrolled" and "collapsed" are included. I guess if these are mandatory fields, I can understand the logic, but I don't think that's the case; I have valid notebooks generated by Jupyter which do not have the "scrolled" field. |
Also, docs list it as "autoscroll" whereas schema and Jupyter use "scrolled" |
Oh, you're right. Thanks! I don't look at the schemas very often... |
This addresses jupyter#47 by documenting the `scrolled` key instead of the `autoscroll` key. Jupyter Notebook doesn't use the autoscroll key and jupyterlab doesn't either.
How's this now? |
I'll get to this within the week.
The text was updated successfully, but these errors were encountered: