adapt to eslint 9

Author: jtpio

.eslintignore

@@ -45,7 +45,7 @@ commander
       try {
         fs.removeSync(destDir);
         console.log('Removed previous destination:', destDir);
-      } catch (e) {
+      } catch {
         console.info('Skip unlink', destDir);
       }
     }

.eslintrc.js

@@ -0,0 +1,90 @@
+import js from '@eslint/js';
+import { defineConfig } from 'eslint/config';
+import tseslint from 'typescript-eslint';
+import prettierConfig from 'eslint-config-prettier';
+import prettierPlugin from 'eslint-plugin-prettier';
+import jestPlugin from 'eslint-plugin-jest';
+import reactPlugin from 'eslint-plugin-react';
+import globals from 'globals';
+
+export default defineConfig([
+  // Global ignores (replaces .eslintignore)
+  {
+    ignores: [
+      'node_modules/**',
+      '**/build/**',
+      '**/lib/**',
+      '**/node_modules/**',
+      '**/mock_packages/**',
+      '**/static/**',
+      '**/typings/**',
+      '**/schemas/**',
+      '**/themes/**',
+      'coverage/**',
+      '**/*.map.js',
+      '**/*.bundle.js',
+      'app/index.template.js',
+      '.idea/**',
+      '.history/**',
+      '.vscode/**',
+      '.pixi/**',
+      '.venv/**',
+      'docs/**',
+      '**/*.js',
+    ],
+  },
+  // Base recommended configs
+  js.configs.recommended,
+  tseslint.configs.recommended,
+  // Main config for TypeScript files
+  {
+    files: ['**/*.{ts,tsx}'],
+    plugins: {
+      prettier: prettierPlugin,
+      jest: jestPlugin,
+      react: reactPlugin,
+    },
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.es2015,
+        ...globals.commonjs,
+        ...globals.node,
+        ...globals.jest,
+      },
+      parserOptions: {
+        project: 'tsconfig.eslint.json',
+      },
+    },
+    settings: {
+      react: {
+        version: 'detect',
+      },
+    },
+    rules: {
+      '@typescript-eslint/naming-convention': [
+        'error',
+        {
+          selector: 'interface',
+          format: ['PascalCase'],
+          custom: {
+            regex: '^I[A-Z]',
+            match: true,
+          },
+        },
+      ],
+      '@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-namespace': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+      '@typescript-eslint/no-use-before-define': 'off',
+      '@typescript-eslint/no-empty-object-type': 'off',
+      'jest/no-done-callback': 'off',
+      curly: ['error', 'all'],
+      eqeqeq: 'error',
+      'prefer-arrow-callback': 'error',
+    },
+  },
+  // Prettier must be last
+  prettierConfig,
+]);

.eslintrc.json

@@ -28,8 +28,8 @@
     "clean": "lerna run clean",
     "deduplicate": "jlpm dlx yarn-berry-deduplicate -s fewerHighest && jlpm install",
     "develop": "jupyter labextension develop . --overwrite && node ./buildutils/lib/develop.js --overwrite",
-    "eslint": "eslint . --ext .ts,.tsx --fix",
-    "eslint:check": "eslint . --ext .ts,.tsx",
+    "eslint": "eslint . --fix",
+    "eslint:check": "eslint .",
     "eslint:files": "eslint --fix",
     "get:lab:version": "node ./buildutils/lib/get-latest-lab-version.js",
     "integrity": "node buildutils/lib/ensure-repo.js",
@@ -51,20 +51,21 @@
     "yjs": "^13.5.40"
   },
   "devDependencies": {
+    "@eslint/js": "^9.26.0",
     "@jupyterlab/buildutils": "~4.6.0-alpha.2",
-    "@typescript-eslint/eslint-plugin": "^5.55.0",
-    "@typescript-eslint/parser": "^5.55.0",
     "eslint": "^9.26.0",
-    "eslint-config-prettier": "^8.7.0",
-    "eslint-plugin-jest": "^27.2.1",
-    "eslint-plugin-prettier": "^4.2.1",
-    "eslint-plugin-react": "^7.32.2",
+    "eslint-config-prettier": "^10.0.0",
+    "eslint-plugin-jest": "^28.0.0",
+    "eslint-plugin-prettier": "^5.0.0",
+    "eslint-plugin-react": "^7.37.0",
+    "globals": "^16.0.0",
     "html-webpack-plugin": "^5.6.3",
     "lerna": "^7.1.4",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.8.5",
     "rimraf": "^3.0.2",
-    "typescript": "~5.5.4"
+    "typescript": "~5.5.4",
+    "typescript-eslint": "^8.0.0"
   },
   "nx": {}
 }

buildutils/src/develop.ts

@@ -155,7 +155,9 @@ const interfaceSwitcher: JupyterFrontEndPlugin<void> = {
 
       commands.addCommand(command, {
         label: (args) => {
-          args.noLabel ? '' : commandLabel;
+          if (args.noLabel) {
+            return '';
+          }
           if (args.isMenu || args.isPalette) {
             return commandDescription;
           }

eslint.config.mjs

@@ -6,7 +6,7 @@
     "buildutils/**/*",
     "ui-tests/**/*",
     "docs/**/*",
-    ".eslintrc.js"
+    "eslint.config.mjs"
   ],
   "compilerOptions": {
     "types": ["jest"]

package.json

@@ -36,7 +36,7 @@ test.describe('Smoke', () => {
     try {
       // we may have to select the kernel first
       await notebook.click('text="Select"', { timeout: 5000 });
-    } catch (e) {
+    } catch {
       // The kernel is already selected
     }