Skip to content

Toolbar button "Restart Kernel and Run All Code..." has no icon #6761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jitseniesen opened this issue Mar 6, 2023 · 2 comments · Fixed by #6757
Closed

Toolbar button "Restart Kernel and Run All Code..." has no icon #6761

jitseniesen opened this issue Mar 6, 2023 · 2 comments · Fixed by #6757
Labels
Milestone

Comments

@jitseniesen
Copy link

Describe the bug
Toolbar button "Restart Kernel and Run All Code..." has no icon

To Reproduce
Steps to reproduce the behavior:

  1. Download source for version 7.0.0a14 (current HEAD)
  2. Create development environment following the instructions in CONTRIBUTING.md
  3. Start Jupyter Notebook and create a new notebook

Expected behavior
The text on the button looks out of place, it should probably be an icon (or perhaps the button should not be in the toolbar at all).

Screenshots
jupyter-notebook

Desktop (please complete the following information):

  • OS: Linux Debian
  • Browser: Firefox
  • Version: 102.8.0esr

Additional context
The issue may well be in how I follow the instructions in CONTRIBUTING.md (though they seem pretty clear) or the instructions themselves. I have very little JavaScript experience and the build process still holds many mysteries for me.

@jitseniesen jitseniesen added the bug label Mar 6, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Mar 6, 2023
@jtpio
Copy link
Member

jtpio commented Mar 6, 2023

Thanks @jitseniesen for the report.

This will likely be fixed by #6757, which should include the fix that landed upstream in JupyterLab: jupyterlab/jupyterlab#14000

@jtpio jtpio added this to the 7.0 milestone Mar 6, 2023
@jtpio jtpio removed the status:Needs Triage Applied to issues that need triage label Mar 6, 2023
@jitseniesen
Copy link
Author

Thanks @jtpio for your quick reply and fix. You probably don't need this, but I can confirm that the latest release fixes the issue.

More broadly, thanks very much to everybody concerned for your work on Jupyter Notebook 7. I am trying to see whether it can be integrated in Spyder. It looks much better than my previous attempt, that was based on the example-notebook distributed with Jupyter Lab.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants