From 88c0eef4d8134586cc0ee9e106fdb0832859b114 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 7 Mar 2023 04:25:48 +0000 Subject: [PATCH 1/4] [pre-commit.ci] pre-commit autoupdate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit updates: - [github.com/charliermarsh/ruff-pre-commit: v0.0.237 → v0.0.254](https://github.com/charliermarsh/ruff-pre-commit/compare/v0.0.237...v0.0.254) --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 5d4122e7ba..f6a1734e30 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -29,7 +29,7 @@ repos: - id: black - repo: https://github.com/charliermarsh/ruff-pre-commit - rev: v0.0.237 + rev: v0.0.254 hooks: - id: ruff args: ["--fix"] From c86e2899021428fb8b77a747b48c9c9cf2fec1b7 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 7 Mar 2023 04:25:58 +0000 Subject: [PATCH 2/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- notebook/app.py | 2 +- ui-tests/test/jupyter_server_config.py | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/notebook/app.py b/notebook/app.py index c81c4abbeb..e4ca63469d 100644 --- a/notebook/app.py +++ b/notebook/app.py @@ -32,7 +32,7 @@ class NotebookBaseHandler(ExtensionHandlerJinjaMixin, ExtensionHandlerMixin, JupyterHandler): """The base notebook API handler.""" - def get_page_config(self): # noqa:C901 + def get_page_config(self): """Get the page config.""" config = LabConfig() app = self.extensionapp diff --git a/ui-tests/test/jupyter_server_config.py b/ui-tests/test/jupyter_server_config.py index 6718f22d59..2c4a719da8 100644 --- a/ui-tests/test/jupyter_server_config.py +++ b/ui-tests/test/jupyter_server_config.py @@ -5,14 +5,14 @@ import jupyterlab c: Any -c.ServerApp.port = 8888 # noqa -c.ServerApp.port_retries = 0 # noqa -c.ServerApp.open_browser = False # noqa +c.ServerApp.port = 8888 +c.ServerApp.port_retries = 0 +c.ServerApp.open_browser = False -c.ServerApp.root_dir = mkdtemp(prefix="galata-test-") # noqa -c.ServerApp.token = "" # noqa -c.ServerApp.password = "" # noqa -c.ServerApp.disable_check_xsrf = True # noqa +c.ServerApp.root_dir = mkdtemp(prefix="galata-test-") +c.ServerApp.token = "" +c.ServerApp.password = "" +c.ServerApp.disable_check_xsrf = True -c.JupyterNotebookApp.expose_app_in_browser = True # noqa +c.JupyterNotebookApp.expose_app_in_browser = True c.LabServerApp.extra_labextensions_path = str(Path(jupyterlab.__file__).parent / "galata") From f5e2fbc7ad490667bd9507fdc4d2fa14ccc58361 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Tue, 7 Mar 2023 14:50:29 +0100 Subject: [PATCH 3/4] Update ruff --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index c2a5c5d982..e7ea503ca7 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -145,7 +145,7 @@ dependencies = [ "black[jupyter]==22.10.0", "mdformat>0.7", "mdformat-gfm>=0.3.5", - "ruff==0.0.237" + "ruff==0.0.254" ] detached = true [tool.hatch.envs.lint.scripts] From df39c30cf291ee20efd7c04dd19edb3d5ae543ca Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Tue, 7 Mar 2023 15:26:20 +0100 Subject: [PATCH 4/4] Lint conftest --- tests/conftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/conftest.py b/tests/conftest.py index a5ce0d48df..80ae8bf28a 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -32,7 +32,7 @@ def mkdir(tmp_path, *parts): @pytest.fixture -def make_notebook_app( +def make_notebook_app( # noqa PLR0913 jp_root_dir, jp_template_dir, app_settings_dir,