Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to add a ServiceAccount to the Prepuller #3442

Open
samyuh opened this issue Jun 23, 2024 · 1 comment · May be fixed by #3441
Open

Not possible to add a ServiceAccount to the Prepuller #3442

samyuh opened this issue Jun 23, 2024 · 1 comment · May be fixed by #3441
Labels
bug

Comments

@samyuh
Copy link

samyuh commented Jun 23, 2024

Bug description

Even though prepuller.hook.serviceaccount is properly configured, these changes aren't applied in the pods

How to reproduce

  1. Configure prepuller.hook.serviceaccount with a service account
  2. Apply the changes
  3. Check that the pod image-puller uses the default service account, even though that was not the service account we defined

Expected behaviour

The Service Account should be properly set

Actual behaviour

The Service Account used is the default and we have no way to change it
@samyuh samyuh added the bug label Jun 23, 2024
@samyuh samyuh linked a pull request Jun 23, 2024 that will close this issue
Open
@samyuh
Copy link
Author

samyuh commented Jun 23, 2024

This bug is fixed by #3441
Can some mantainer review it? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(daemonset): Allow the definition a ServiceAccount in DaemonSets samyuh/zero-to-jupyterhub-k8s
1 participant
@samyuh