Replace MUI Components with Jupyterlab UI toolkit#1301
Open
Zxun2 wants to merge 15 commits intojupyterlab:mainfrom
Open
Replace MUI Components with Jupyterlab UI toolkit#1301Zxun2 wants to merge 15 commits intojupyterlab:mainfrom
Zxun2 wants to merge 15 commits intojupyterlab:mainfrom
Conversation
|
|
fcollonval
reviewed
Nov 27, 2023
Member
fcollonval
left a comment
fcollonval
left a comment
There was a problem hiding this comment.
Hey @Zxun2
Thanks for working on this. I see that you are based on the main branch prior to the migration to JupyterLab 4. Would you mind migrating to the main branch latest commit?
fcollonval
requested changes
Dec 7, 2023
Member
fcollonval
left a comment
fcollonval
left a comment
There was a problem hiding this comment.
Thanks @Zxun2
The action buttons are too big by default. I got something more acceptable by setting the following CSS property in actionButtonStyle (src/style/ActionButtonStyle.ts):
// @ts-expect-error unknown prop
'--density': -1,
Comment on lines
+43
to
+53
| <> | ||
| <Tooltip anchor={title}>{title}</Tooltip> | ||
| <Button | ||
| id={title} | ||
| className={classes(actionButtonStyle, className)} | ||
| disabled={disabled} | ||
| onClick={onClick} | ||
| > | ||
| <icon.react elementPosition="center" tag="span" /> | ||
| </Button> | ||
| </> |
Member
There was a problem hiding this comment.
I would simply keep the title without introducing a tooltip
Suggested change
| <> | |
| <Tooltip anchor={title}>{title}</Tooltip> | |
| <Button | |
| id={title} | |
| className={classes(actionButtonStyle, className)} | |
| disabled={disabled} | |
| onClick={onClick} | |
| > | |
| <icon.react elementPosition="center" tag="span" /> | |
| </Button> | |
| </> | |
| <Button | |
| title={title} | |
| className={classes(actionButtonStyle, className)} | |
| disabled={disabled} | |
| onClick={onClick} | |
| > | |
| <icon.react elementPosition="center" tag="span" /> | |
| </Button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes