Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Sep 10, 2024

Follow-up to #245

Fixes jupyter/notebook#7456
Closes jupyter/notebook#7457

We likely need include-hidden-files to be set for actions/upload-artifact/merge@v4 too.

@jtpio jtpio added the bug Something isn't working label Sep 10, 2024
@jtpio
Copy link
Member Author

jtpio commented Sep 10, 2024

This seems be fixing it fully this time, as noticed in jupyter/notebook#7457 using this branch directly.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make's sense, thank you!

@krassowski krassowski merged commit d14b6d2 into jupyterlab:main Sep 10, 2024
@jtpio jtpio deleted the include-hidden-files-2 branch September 10, 2024 16:54
@jtpio
Copy link
Member Author

jtpio commented Sep 10, 2024

Starting a new release to have this available in the @v1 actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage check is failing on CI

2 participants