Skip to content

Commit 7ed3b56

Browse files
authored
Merge branch 'main' into dsw-000-uncontrolled-form-react
2 parents 1004b9d + 6dacb08 commit 7ed3b56

File tree

9 files changed

+2075
-3187
lines changed

9 files changed

+2075
-3187
lines changed

nextjs-app-v14/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@
1414
"upgrade-pie-packages": "npx npm-check-updates \"@justeattakeaway/pie-*\" -u"
1515
},
1616
"dependencies": {
17-
"@justeattakeaway/pie-cookie-banner": "0.26.5",
1817
"@justeattakeaway/pie-css": "0.13.0",
1918
"@justeattakeaway/pie-icons-webc": "0.25.1",
20-
"@justeattakeaway/pie-webc": "0.5.42",
19+
"@justeattakeaway/pie-webc": "0.5.53",
2120
"@lit-labs/nextjs": "0.2.0",
2221
"@lit/react": "1.0.5",
2322
"next": "14.2.3",

nextjs-app-v14/src/app/components/cookie-banner/cookie-banner.tsx

+2-4
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,14 @@
22

33
import NavigationLayout from "@/app/layout/navigation";
44
import { PieCookieBanner } from '@justeattakeaway/pie-webc/react/cookie-banner.js';
5-
// TODO: Remove this comment as soon as we provide the TS declaration for locales
6-
// @ts-ignore: missing declaration for locales
7-
import daDK from '@justeattakeaway/pie-cookie-banner/locales/da-dk.json';
85

96
export default function CookieBanner() {
107
return (
118
<NavigationLayout title="Cookie Banner">
129
<PieCookieBanner
1310
defaultPreferences={{functional: true, personalized: true, analytical: true}}
14-
locale={daDK}
11+
language="da"
12+
country="dk"
1513
hasPrimaryActionsOnly
1614
cookieTechnologiesLink="https://justeattakeaway.com"
1715
cookieStatementLink="https://justeattakeaway.com" />

nuxt-app/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,9 @@
1919
"sass": "1.70.0"
2020
},
2121
"dependencies": {
22-
"@justeattakeaway/pie-cookie-banner": "0.26.5",
2322
"@justeattakeaway/pie-css": "0.13.0",
2423
"@justeattakeaway/pie-icons-webc": "0.25.1",
25-
"@justeattakeaway/pie-webc": "0.5.42",
24+
"@justeattakeaway/pie-webc": "0.5.53",
2625
"just-kebab-case": "4.2.0",
2726
"nuxt-ssr-lit": "1.6.16"
2827
},

nuxt-app/pages/components/cookie-banner.vue

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<div>
3-
<pie-cookie-banner hasPrimaryActionsOnly :locale="daDK" cookieTechnologiesLink="https://justeattakeaway.com"
3+
<pie-cookie-banner hasPrimaryActionsOnly language="da" country="dk" cookieTechnologiesLink="https://justeattakeaway.com"
44
cookieStatementLink="https://justeattakeaway.com">
55
</pie-cookie-banner>
66
</div>
@@ -14,7 +14,4 @@ definePageMeta({
1414
title: 'Cookie Banner',
1515
});
1616
17-
// TODO: DSW-1710 - Update this to use the TS declaration for locales.
18-
// Currently importing the JSON file directly as a workaround as Nuxt wants import assertions.
19-
import daDK from '@justeattakeaway/pie-cookie-banner/locales/da-dk.json';
2017
</script>

turbo.json

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"pipeline": {
44
"preview": {
55
"cache": false,
6+
"persistent": true,
67
"dependsOn": ["build"]
78
},
89
"test:ssr": {

vanilla-app/js/cookie-banner.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import '@justeattakeaway/pie-webc/components/cookie-banner.js';
2-
import daDK from '@justeattakeaway/pie-cookie-banner/locales/da-dk.json';
32
import './utils/navigation.js';
43
import './shared.js';
54

65
document.querySelector('#app').innerHTML = `
76
<pie-cookie-banner
8-
locale='${JSON.stringify(daDK)}'
7+
language="da"
8+
country="dk"
99
hasPrimaryActionsOnly
1010
cookieTechnologiesLink="https://justeattakeaway.com"
1111
cookieStatementLink="https://justeattakeaway.com"></pie-cookie-banner>`;

vanilla-app/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818
"vite-plugin-html-inject": "1.1.2"
1919
},
2020
"dependencies": {
21-
"@justeattakeaway/pie-cookie-banner": "0.26.5",
2221
"@justeattakeaway/pie-css": "0.13.0",
2322
"@justeattakeaway/pie-icons-webc": "0.25.1",
24-
"@justeattakeaway/pie-webc": "0.5.42"
23+
"@justeattakeaway/pie-webc": "0.5.53"
2524
},
2625
"installConfig": {
2726
"hoistingLimits": "workspaces"

wdio.conf.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const capabilities = [
1111
createCapability("Windows", "11", "Firefox", "127"),
1212
createCapability(null, "18", "Safari", null, "iPhone 16"),
1313
createCapability(null, "16", "Safari", null, "iPhone 14"),
14-
createCapability(null, "14.0", "Chrome", null, "Google Pixel 9"),
14+
createCapability(null, "15.0", "Chrome", null, "Google Pixel 9"),
1515
createCapability(null, "11.0", "Chrome", null, "Google Pixel 6")
1616
];
1717

0 commit comments

Comments
 (0)