Skip to content

Commit 4546d1c

Browse files
committed
feat(pie-css): DSW-2172 node_modules include to loadPaths of compileCss func
1 parent 1a0f990 commit 4546d1c

File tree

8 files changed

+41
-16
lines changed

8 files changed

+41
-16
lines changed

.changeset/chatty-hotels-reflect.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@justeattakeaway/pie-cookie-banner": minor
3+
"@justeattakeaway/pie-modal": minor
4+
---
5+
6+
[Removed] - pie-design-tokens dependency.

.changeset/nasty-garlics-thank.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@justeattakeaway/pie-css": minor
3+
---
4+
5+
[Changed] - replaces hardcoded breakpoint values with PIE tokens.

.changeset/sweet-planes-clap.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@justeattakeaway/pie-notification": minor
3+
"@justeattakeaway/pie-modal": minor
4+
---
5+
6+
[Changed] - replaces media with include-media with pie breakpoints tokens.

.changeset/wise-ants-reflect.md

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
"wc-vanilla": minor
3+
"pie-storybook": minor
4+
"pie-docs": minor
5+
"pie-monorepo": minor
6+
---
7+
8+
[Changed] - pie-design-tokens version bump to 6.5.0.

packages/components/pie-notification/src/notification.scss

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@use '@justeattakeaway/pie-css/scss' as p;
2+
@use '@justeattakeaway/pie-css/scss/settings' as *;
23

34
.c-notification {
45
--notification-border-radius: var(--dt-radius-rounded-c);

packages/tools/pie-css/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
"repository": "https://github.com/justeattakeaway/pie.git",
2828
"license": "Apache-2.0",
2929
"devDependencies": {
30-
"@justeat/pie-design-tokens": "6.5.0",
3130
"@types/postcss-import": "14.0.3",
3231
"include-media": "2.0.0",
3332
"postcss": "8.4.32",

packages/tools/pie-css/utilities/compileCss.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ import sass from 'sass';
1515
*/
1616
export function compileCss (scss: string): string {
1717
const result = sass.compileString(scss, {
18-
loadPaths: ['scss'],
18+
// root level node_modules are here for external dependencies imports like pie-design-tokens
19+
loadPaths: ['scss', '../../../node_modules'],
1920
});
2021

2122
return result.css;

yarn.lock

+13-14
Original file line numberDiff line numberDiff line change
@@ -5508,7 +5508,7 @@ __metadata:
55085508
languageName: unknown
55095509
linkType: soft
55105510

5511-
"@justeattakeaway/pie-checkbox@0.12.3, @justeattakeaway/pie-checkbox@workspace:packages/components/pie-checkbox":
5511+
"@justeattakeaway/pie-checkbox@0.13.0, @justeattakeaway/pie-checkbox@workspace:packages/components/pie-checkbox":
55125512
version: 0.0.0-use.local
55135513
resolution: "@justeattakeaway/pie-checkbox@workspace:packages/components/pie-checkbox"
55145514
dependencies:
@@ -5570,7 +5570,6 @@ __metadata:
55705570
version: 0.0.0-use.local
55715571
resolution: "@justeattakeaway/pie-css@workspace:packages/tools/pie-css"
55725572
dependencies:
5573-
"@justeat/pie-design-tokens": 6.5.0
55745573
"@types/postcss-import": 14.0.3
55755574
include-media: 2.0.0
55765575
postcss: 8.4.32
@@ -5905,14 +5904,14 @@ __metadata:
59055904
languageName: unknown
59065905
linkType: soft
59075906

5908-
"@justeattakeaway/[email protected].33, @justeattakeaway/pie-webc@workspace:packages/components/pie-webc":
5907+
"@justeattakeaway/[email protected].34, @justeattakeaway/pie-webc@workspace:packages/components/pie-webc":
59095908
version: 0.0.0-use.local
59105909
resolution: "@justeattakeaway/pie-webc@workspace:packages/components/pie-webc"
59115910
dependencies:
59125911
"@justeattakeaway/pie-assistive-text": 0.7.1
59135912
"@justeattakeaway/pie-button": 0.49.1
59145913
"@justeattakeaway/pie-card": 0.20.1
5915-
"@justeattakeaway/pie-checkbox": 0.12.3
5914+
"@justeattakeaway/pie-checkbox": 0.13.0
59165915
"@justeattakeaway/pie-checkbox-group": 0.7.0
59175916
"@justeattakeaway/pie-chip": 0.8.3
59185917
"@justeattakeaway/pie-components-config": 0.18.0
@@ -26225,7 +26224,7 @@ __metadata:
2622526224
"@justeattakeaway/pie-assistive-text": 0.7.1
2622626225
"@justeattakeaway/pie-button": 0.49.1
2622726226
"@justeattakeaway/pie-card": 0.20.1
26228-
"@justeattakeaway/pie-checkbox": 0.12.3
26227+
"@justeattakeaway/pie-checkbox": 0.13.0
2622926228
"@justeattakeaway/pie-checkbox-group": 0.7.0
2623026229
"@justeattakeaway/pie-chip": 0.8.3
2623126230
"@justeattakeaway/pie-cookie-banner": 0.26.4
@@ -34176,7 +34175,7 @@ __metadata:
3417634175
"@angular/platform-browser-dynamic": 15.2.0
3417734176
"@angular/router": 15.2.0
3417834177
"@justeattakeaway/pie-css": 0.12.1
34179-
"@justeattakeaway/pie-webc": 0.5.33
34178+
"@justeattakeaway/pie-webc": 0.5.34
3418034179
rxjs: 7.8.0
3418134180
tslib: 2.3.0
3418234181
typescript: 4.9.4
@@ -34193,7 +34192,7 @@ __metadata:
3419334192
"@babel/preset-env": 7.24.5
3419434193
"@babel/preset-react": 7.24.1
3419534194
"@justeattakeaway/pie-css": 0.12.1
34196-
"@justeattakeaway/pie-webc": 0.5.33
34195+
"@justeattakeaway/pie-webc": 0.5.34
3419734196
"@lit/react": 1.0.2
3419834197
babel-loader: 8
3419934198
eslint: 8.37.0
@@ -34210,7 +34209,7 @@ __metadata:
3421034209
resolution: "wc-next13@workspace:apps/examples/wc-next13"
3421134210
dependencies:
3421234211
"@justeattakeaway/pie-css": 0.12.1
34213-
"@justeattakeaway/pie-webc": 0.5.33
34212+
"@justeattakeaway/pie-webc": 0.5.34
3421434213
"@lit-labs/nextjs": 0.2.0
3421534214
"@lit/react": 1.0.5
3421634215
"@types/react": 18.3.3
@@ -34233,7 +34232,7 @@ __metadata:
3423334232
dependencies:
3423434233
"@babel/preset-env": 7.24.5
3423534234
"@justeattakeaway/pie-css": 0.12.1
34236-
"@justeattakeaway/pie-webc": 0.5.33
34235+
"@justeattakeaway/pie-webc": 0.5.34
3423734236
babel-loader: 8
3423834237
core-js: 3.30.0
3423934238
nuxt: 2.17.0
@@ -34248,7 +34247,7 @@ __metadata:
3424834247
resolution: "wc-nuxt3@workspace:apps/examples/wc-nuxt3"
3424934248
dependencies:
3425034249
"@justeattakeaway/pie-css": 0.12.1
34251-
"@justeattakeaway/pie-webc": 0.5.33
34250+
"@justeattakeaway/pie-webc": 0.5.34
3425234251
"@types/node": 18
3425334252
nuxt: 3.4.3
3425434253
nuxt-ssr-lit: 1.6.5
@@ -34260,7 +34259,7 @@ __metadata:
3426034259
resolution: "wc-react17@workspace:apps/examples/wc-react17"
3426134260
dependencies:
3426234261
"@justeattakeaway/pie-css": 0.12.1
34263-
"@justeattakeaway/pie-webc": 0.5.33
34262+
"@justeattakeaway/pie-webc": 0.5.34
3426434263
"@lit/react": 1.0.5
3426534264
"@types/react": ^17.0.2
3426634265
"@types/react-dom": ^17.0.2
@@ -34280,7 +34279,7 @@ __metadata:
3428034279
resolution: "wc-react18@workspace:apps/examples/wc-react18"
3428134280
dependencies:
3428234281
"@justeattakeaway/pie-css": 0.12.1
34283-
"@justeattakeaway/pie-webc": 0.5.33
34282+
"@justeattakeaway/pie-webc": 0.5.34
3428434283
"@lit/react": 1.0.5
3428534284
"@types/react": 18.3.3
3428634285
"@types/react-dom": 18.3.0
@@ -34302,7 +34301,7 @@ __metadata:
3430234301
"@justeat/pie-design-tokens": 6.5.0
3430334302
"@justeattakeaway/pie-css": 0.12.1
3430434303
"@justeattakeaway/pie-icons-webc": 0.25.1
34305-
"@justeattakeaway/pie-webc": 0.5.33
34304+
"@justeattakeaway/pie-webc": 0.5.34
3430634305
vite: 4.5.3
3430734306
languageName: unknown
3430834307
linkType: soft
@@ -34312,7 +34311,7 @@ __metadata:
3431234311
resolution: "wc-vue3@workspace:apps/examples/wc-vue3"
3431334312
dependencies:
3431434313
"@justeattakeaway/pie-css": 0.12.1
34315-
"@justeattakeaway/pie-webc": 0.5.33
34314+
"@justeattakeaway/pie-webc": 0.5.34
3431634315
"@types/node": 18.15.11
3431734316
"@vitejs/plugin-vue": 4.0.0
3431834317
"@vue/tsconfig": 0.1.3

0 commit comments

Comments
 (0)