Skip to content

Commit 8154537

Browse files
committed
feat(pie-css): DSW-2172 node_modules include to loadPaths of compileCss func
1 parent 787e8b0 commit 8154537

File tree

10 files changed

+31
-5
lines changed

10 files changed

+31
-5
lines changed

.changeset/chatty-hotels-reflect.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@justeattakeaway/pie-cookie-banner": minor
3+
"@justeattakeaway/pie-modal": minor
4+
---
5+
6+
[Removed] - pie-design-tokens dependency.

.changeset/nasty-garlics-thank.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@justeattakeaway/pie-css": minor
3+
---
4+
5+
[Changed] - replaces hardcoded breakpoint values with PIE tokens.

.changeset/sweet-planes-clap.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@justeattakeaway/pie-notification": minor
3+
"@justeattakeaway/pie-modal": minor
4+
---
5+
6+
[Changed] - replaces media with include-media with pie breakpoints tokens.

.changeset/wise-ants-reflect.md

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
"wc-vanilla": minor
3+
"pie-storybook": minor
4+
"pie-docs": minor
5+
"pie-monorepo": minor
6+
---
7+
8+
[Changed] - pie-design-tokens version bump to 6.5.0.

apps/pie-docs/src/__tests__/_11ty/shortcodes/__snapshots__/tokensTable.test.js.snap

+2-2
Large diffs are not rendered by default.

packages/components/pie-modal/src/modal.scss

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
@use '@justeattakeaway/pie-css/scss' as p;
12
@use '@justeattakeaway/pie-css/scss/settings' as *;
23
@use 'dialog-polyfill/dist/dialog-polyfill.css';
34

packages/components/pie-notification/src/notification.scss

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@use '@justeattakeaway/pie-css/scss' as p;
2+
@use '@justeattakeaway/pie-css/scss/settings' as *;
23

34
.c-notification {
45
--notification-border-radius: var(--dt-radius-rounded-c);

packages/tools/pie-css/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
"repository": "https://github.com/justeattakeaway/pie.git",
2828
"license": "Apache-2.0",
2929
"devDependencies": {
30-
"@justeat/pie-design-tokens": "6.5.0",
3130
"@types/postcss-import": "14.0.3",
3231
"include-media": "2.0.0",
3332
"postcss": "8.4.32",

packages/tools/pie-css/utilities/compileCss.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ import sass from 'sass';
1515
*/
1616
export function compileCss (scss: string): string {
1717
const result = sass.compileString(scss, {
18-
loadPaths: ['scss'],
18+
// root level node_modules are here for external dependencies imports like pie-design-tokens
19+
loadPaths: ['scss', '../../../node_modules'],
1920
});
2021

2122
return result.css;

yarn.lock

-1
Original file line numberDiff line numberDiff line change
@@ -5570,7 +5570,6 @@ __metadata:
55705570
version: 0.0.0-use.local
55715571
resolution: "@justeattakeaway/pie-css@workspace:packages/tools/pie-css"
55725572
dependencies:
5573-
"@justeat/pie-design-tokens": 6.5.0
55745573
"@types/postcss-import": 14.0.3
55755574
include-media: 2.0.0
55765575
postcss: 8.4.32

0 commit comments

Comments
 (0)