Skip to content

Commit a18f69f

Browse files
siggerzzBen Siggery
and
Ben Siggery
authored
fix(pie-monorepo): DSW-000 fix cdn upload (#2263)
* test upload * test upload * reintroduce logic --------- Co-authored-by: Ben Siggery <[email protected]>
1 parent ac6a64f commit a18f69f

File tree

3 files changed

+34
-53
lines changed

3 files changed

+34
-53
lines changed

.changeset/stupid-bottles-do.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"pie-monorepo": patch
3+
---
4+
5+
[Fixed] - CDN publish logic v2

.github/workflows/changeset-release.yml

+29-9
Original file line numberDiff line numberDiff line change
@@ -207,15 +207,35 @@ jobs:
207207
runs-on: ${{ inputs.os }}
208208
if: needs.changesets.outputs.published == 'true' && contains(fromJson(needs.changesets.outputs.publishedPackages).*.name, '@justeattakeaway/pie-cookie-banner')
209209
steps:
210+
# Checkout the Repo
211+
- name: Checkout
212+
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
213+
214+
# Setup Repo
215+
- name: Setup Repo
216+
uses: ./.github/actions/setup-repo
217+
with:
218+
node-version: ${{ inputs.node-version }}
219+
os: ${{ inputs.os }}
220+
221+
# Build
222+
- name: Build Cookie Banner
223+
uses: ./.github/actions/run-script
224+
with:
225+
script-name: "build --filter=pie-cookie-banner"
226+
210227
- name: Extract cookie banner version
211228
id: extract-version
212229
run: |
213-
PACKAGES='${{ needs.changesets.outputs.publishedPackages}}'
214-
COOKIE_BANNER_VERSION=$(echo $PACKAGES | jq -r '.[] | select(.name == "@justeattakeaway/pie-cookie-banner") | .version')
215-
echo "cookie_banner_version=$COOKIE_BANNER_VERSION" >> $GITHUB_OUTPUT
216-
- name: Publish Cookie Banner CDN
217-
uses: ./.github/workflows/pie-cookie-banner-cdn-publish.yml
218-
with:
219-
os: ${{ inputs.os }}
220-
node-version: ${{ inputs.node-version }}
221-
package-version: v${{ steps.extract-version.outputs.cookie_banner_version }}
230+
PACKAGES='${{ needs.changesets.outputs.publishedPackages }}'
231+
cookie_banner_version=$(echo $PACKAGES | jq -r '.[] | select(.name == "@justeattakeaway/pie-cookie-banner") | .version')
232+
echo "COOKIE_BANNER_VERSION=$cookie_banner_version" >> $GITHUB_ENV
233+
234+
- name: Upload to S3
235+
run: |
236+
aws s3 sync $GITHUB_WORKSPACE/packages/components/pie-cookie-banner/cdn_dist/ s3://$PIE_CDN_BUCKET_NAME/pie-cookie-banner/$COOKIE_BANNER_VERSION/ --region $AWS_REGION --content-type "text/javascript"
237+
env:
238+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_KEY_ID }}
239+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
240+
AWS_REGION: eu-west-1
241+
PIE_CDN_BUCKET_NAME: ${{ vars.PIE_CDN_BUCKET_NAME }}

.github/workflows/pie-cookie-banner-cdn-publish.yml

-44
This file was deleted.

0 commit comments

Comments
 (0)