Skip to content

Commit b3ce986

Browse files
revert(pie-monorepo): DSW-000 auto updated lockfile and dangerjs check for missing lock file (#1726)
Revert "chore(pie-monorepo): DSW-000 auto updated lockfile and dangerjs check…" This reverts commit 936817f.
1 parent 936817f commit b3ce986

File tree

4 files changed

+19
-87
lines changed

4 files changed

+19
-87
lines changed

.changeset/nice-clocks-prove.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.github/workflows/ci.yml

Lines changed: 1 addition & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -56,50 +56,8 @@ jobs:
5656
secrets:
5757
githubToken: ${{ secrets.GITHUB_TOKEN }}
5858

59-
update-lockfile:
60-
runs-on: ubuntu-latest
61-
if: github.actor == 'pie-design-system-bot'|| github.actor == 'renovate[bot]' || contains(github.ref_name, 'changeset-release/main')
62-
permissions:
63-
# Give the default GITHUB_TOKEN write permission to commit and push the
64-
# added or changed files to the repository.
65-
contents: write
66-
67-
steps:
68-
- name: Checkout
69-
uses: actions/checkout@v3
70-
with:
71-
fetch-depth: 0
72-
# Setup Repo
73-
- name: Setup Repo
74-
uses: ./.github/actions/setup-repo
75-
with:
76-
node-version: 20
77-
os: ubuntu-latest
78-
79-
# Check if yarn.lock has changed
80-
- name: Check if yarn.lock was updated
81-
id: yarn_lock_check
82-
run: |
83-
if git diff --quiet yarn.lock; then
84-
echo "lockfile_changed=false" >> $GITHUB_ENV
85-
else
86-
echo "lockfile_changed=true" >> $GITHUB_ENV
87-
fi
88-
89-
# Commit and push changes if yarn.lock was updated
90-
- name: Commit and push changes
91-
if: env.lockfile_changed == 'true'
92-
uses: stefanzweifel/git-auto-commit-action@v5
93-
with:
94-
commit_message: "chore(pie-monorepo): DSW-000 auto update lockfile"
95-
env:
96-
HUSKY: 0 # Disable Husky hooks
97-
9859
check-change-type:
9960
name: Get change type
100-
needs: ['update-lockfile']
101-
# Ensures this job runs even if 'update-lockfile' step is skipped
102-
if: always()
10361
runs-on: ubuntu-latest
10462
outputs:
10563
pie-docs-change: ${{ steps.docs-check.outputs.docs-change }}
@@ -384,5 +342,5 @@ jobs:
384342
uses: re-actors/alls-green@release/v1
385343
with:
386344
# "allowed-skips" lists jobs that are optional but should not fail
387-
allowed-skips: browser-tests-components, deploy-docs, deploy-storybook, browser-tests-docs, build-ubuntu-node-20, unit-tests
345+
allowed-skips: browser-tests-components, deploy-docs, deploy-storybook, browser-tests-docs
388346
jobs: ${{ toJSON(needs) }}

dangerfile.js

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,10 @@
11
import { danger, fail } from 'danger';
22

3-
const { execSync } = require('child_process');
4-
53
const { pr } = danger.github;
64
const validChangesetCategories = ['Added', 'Changed', 'Removed', 'Fixed'];
75

86
const isRenovatePR = pr.user.login === 'renovate[bot]';
97
const isDependabotPR = pr.user.login === 'dependabot[bot]';
10-
const isPiebotPR = pr.user.login === 'pie-design-system-bot';
11-
12-
// Only run the yarn lock check if the PR is not authored by the PIE bot
13-
if (!isPiebotPR) {
14-
try {
15-
// Run `yarn`
16-
execSync('yarn', { stdio: 'inherit' });
17-
18-
// Check if the lockfile has changed
19-
const lockfileDiff = execSync('git diff --name-only yarn.lock').toString().trim();
20-
21-
if (lockfileDiff) {
22-
fail(':lock: It looks like your `yarn.lock` file has changed after running `yarn`. Please commit the updated lockfile.');
23-
}
24-
} catch (error) {
25-
console.error('Failed to run yarn or check lockfile changes', error);
26-
fail(':exclamation: There was an error running `yarn` or checking for lockfile changes.');
27-
}
28-
}
298

309
// Check for correct Changeset formatting
3110
danger.git.created_files.filter((filepath) => filepath.includes('.changeset/') && !filepath.includes('.changeset/pre.json'))

yarn.lock

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5547,7 +5547,7 @@ __metadata:
55475547
languageName: unknown
55485548
linkType: soft
55495549

5550-
"@justeattakeaway/pie-cookie-banner@0.25.1, @justeattakeaway/pie-cookie-banner@workspace:packages/components/pie-cookie-banner":
5550+
"@justeattakeaway/pie-cookie-banner@0.25.0, @justeattakeaway/pie-cookie-banner@workspace:packages/components/pie-cookie-banner":
55515551
version: 0.0.0-use.local
55525552
resolution: "@justeattakeaway/pie-cookie-banner@workspace:packages/components/pie-cookie-banner"
55535553
dependencies:
@@ -5560,7 +5560,7 @@ __metadata:
55605560
"@justeattakeaway/pie-icon-button": 0.28.10
55615561
"@justeattakeaway/pie-link": 0.17.8
55625562
"@justeattakeaway/pie-modal": 0.46.0
5563-
"@justeattakeaway/pie-switch": 0.30.0
5563+
"@justeattakeaway/pie-switch": 0.29.12
55645564
"@justeattakeaway/pie-webc-core": 0.24.0
55655565
"@justeattakeaway/pie-wrapper-react": 0.14.1
55665566
cem-plugin-module-file-extensions: 0.0.5
@@ -5599,7 +5599,7 @@ __metadata:
55995599
"@custom-elements-manifest/analyzer": 0.9.0
56005600
"@justeattakeaway/pie-components-config": 0.17.0
56015601
"@justeattakeaway/pie-css": 0.12.1
5602-
"@justeattakeaway/pie-switch": 0.30.0
5602+
"@justeattakeaway/pie-switch": 0.29.12
56035603
"@justeattakeaway/pie-text-input": 0.23.4
56045604
"@justeattakeaway/pie-webc-core": 0.24.0
56055605
"@justeattakeaway/pie-wrapper-react": 0.14.1
@@ -5774,7 +5774,7 @@ __metadata:
57745774
languageName: unknown
57755775
linkType: soft
57765776

5777-
"@justeattakeaway/pie-switch@0.30.0, @justeattakeaway/pie-switch@workspace:packages/components/pie-switch":
5777+
"@justeattakeaway/pie-switch@0.29.12, @justeattakeaway/pie-switch@workspace:packages/components/pie-switch":
57785778
version: 0.0.0-use.local
57795779
resolution: "@justeattakeaway/pie-switch@workspace:packages/components/pie-switch"
57805780
dependencies:
@@ -5869,7 +5869,7 @@ __metadata:
58695869
languageName: unknown
58705870
linkType: soft
58715871

5872-
"@justeattakeaway/pie-webc@0.5.24, @justeattakeaway/pie-webc@workspace:packages/components/pie-webc":
5872+
"@justeattakeaway/pie-webc@0.5.23, @justeattakeaway/pie-webc@workspace:packages/components/pie-webc":
58735873
version: 0.0.0-use.local
58745874
resolution: "@justeattakeaway/pie-webc@workspace:packages/components/pie-webc"
58755875
dependencies:
@@ -5880,15 +5880,15 @@ __metadata:
58805880
"@justeattakeaway/pie-checkbox-group": 0.6.1
58815881
"@justeattakeaway/pie-chip": 0.7.2
58825882
"@justeattakeaway/pie-components-config": 0.17.0
5883-
"@justeattakeaway/pie-cookie-banner": 0.25.1
5883+
"@justeattakeaway/pie-cookie-banner": 0.25.0
58845884
"@justeattakeaway/pie-divider": 0.13.9
58855885
"@justeattakeaway/pie-form-label": 0.14.1
58865886
"@justeattakeaway/pie-icon-button": 0.28.10
58875887
"@justeattakeaway/pie-link": 0.17.8
58885888
"@justeattakeaway/pie-modal": 0.46.0
58895889
"@justeattakeaway/pie-notification": 0.10.0
58905890
"@justeattakeaway/pie-spinner": 0.6.7
5891-
"@justeattakeaway/pie-switch": 0.30.0
5891+
"@justeattakeaway/pie-switch": 0.29.12
58925892
"@justeattakeaway/pie-tag": 0.9.9
58935893
"@justeattakeaway/pie-text-input": 0.23.4
58945894
"@justeattakeaway/pie-textarea": 0.7.0
@@ -26003,7 +26003,7 @@ __metadata:
2600326003
"@justeattakeaway/pie-checkbox": 0.12.1
2600426004
"@justeattakeaway/pie-checkbox-group": 0.6.1
2600526005
"@justeattakeaway/pie-chip": 0.7.2
26006-
"@justeattakeaway/pie-cookie-banner": 0.25.1
26006+
"@justeattakeaway/pie-cookie-banner": 0.25.0
2600726007
"@justeattakeaway/pie-css": 0.12.1
2600826008
"@justeattakeaway/pie-divider": 0.13.9
2600926009
"@justeattakeaway/pie-form-label": 0.14.1
@@ -26014,7 +26014,7 @@ __metadata:
2601426014
"@justeattakeaway/pie-modal": 0.46.0
2601526015
"@justeattakeaway/pie-notification": 0.10.0
2601626016
"@justeattakeaway/pie-spinner": 0.6.7
26017-
"@justeattakeaway/pie-switch": 0.30.0
26017+
"@justeattakeaway/pie-switch": 0.29.12
2601826018
"@justeattakeaway/pie-tag": 0.9.9
2601926019
"@justeattakeaway/pie-text-input": 0.23.4
2602026020
"@justeattakeaway/pie-textarea": 0.7.0
@@ -33939,7 +33939,7 @@ __metadata:
3393933939
"@angular/platform-browser-dynamic": 15.2.0
3394033940
"@angular/router": 15.2.0
3394133941
"@justeattakeaway/pie-css": 0.12.1
33942-
"@justeattakeaway/pie-webc": 0.5.24
33942+
"@justeattakeaway/pie-webc": 0.5.23
3394333943
rxjs: 7.8.0
3394433944
tslib: 2.3.0
3394533945
typescript: 4.9.4
@@ -33956,7 +33956,7 @@ __metadata:
3395633956
"@babel/preset-env": 7.24.5
3395733957
"@babel/preset-react": 7.24.1
3395833958
"@justeattakeaway/pie-css": 0.12.1
33959-
"@justeattakeaway/pie-webc": 0.5.24
33959+
"@justeattakeaway/pie-webc": 0.5.23
3396033960
"@lit/react": 1.0.2
3396133961
babel-loader: 8
3396233962
eslint: 8.37.0
@@ -33973,7 +33973,7 @@ __metadata:
3397333973
resolution: "wc-next13@workspace:apps/examples/wc-next13"
3397433974
dependencies:
3397533975
"@justeattakeaway/pie-css": 0.12.1
33976-
"@justeattakeaway/pie-webc": 0.5.24
33976+
"@justeattakeaway/pie-webc": 0.5.23
3397733977
"@lit-labs/nextjs": 0.2.0
3397833978
"@lit/react": 1.0.5
3397933979
"@types/react": 18.3.3
@@ -33996,7 +33996,7 @@ __metadata:
3399633996
dependencies:
3399733997
"@babel/preset-env": 7.24.5
3399833998
"@justeattakeaway/pie-css": 0.12.1
33999-
"@justeattakeaway/pie-webc": 0.5.24
33999+
"@justeattakeaway/pie-webc": 0.5.23
3400034000
babel-loader: 8
3400134001
core-js: 3.30.0
3400234002
nuxt: 2.17.0
@@ -34011,7 +34011,7 @@ __metadata:
3401134011
resolution: "wc-nuxt3@workspace:apps/examples/wc-nuxt3"
3401234012
dependencies:
3401334013
"@justeattakeaway/pie-css": 0.12.1
34014-
"@justeattakeaway/pie-webc": 0.5.24
34014+
"@justeattakeaway/pie-webc": 0.5.23
3401534015
"@types/node": 18
3401634016
nuxt: 3.4.3
3401734017
nuxt-ssr-lit: 1.6.5
@@ -34023,7 +34023,7 @@ __metadata:
3402334023
resolution: "wc-react17@workspace:apps/examples/wc-react17"
3402434024
dependencies:
3402534025
"@justeattakeaway/pie-css": 0.12.1
34026-
"@justeattakeaway/pie-webc": 0.5.24
34026+
"@justeattakeaway/pie-webc": 0.5.23
3402734027
"@lit/react": 1.0.5
3402834028
"@types/react": ^17.0.2
3402934029
"@types/react-dom": ^17.0.2
@@ -34043,7 +34043,7 @@ __metadata:
3404334043
resolution: "wc-react18@workspace:apps/examples/wc-react18"
3404434044
dependencies:
3404534045
"@justeattakeaway/pie-css": 0.12.1
34046-
"@justeattakeaway/pie-webc": 0.5.24
34046+
"@justeattakeaway/pie-webc": 0.5.23
3404734047
"@lit/react": 1.0.5
3404834048
"@types/react": 18.3.3
3404934049
"@types/react-dom": 18.3.0
@@ -34065,7 +34065,7 @@ __metadata:
3406534065
"@justeat/pie-design-tokens": 6.3.1
3406634066
"@justeattakeaway/pie-css": 0.12.1
3406734067
"@justeattakeaway/pie-icons-webc": 0.25.0
34068-
"@justeattakeaway/pie-webc": 0.5.24
34068+
"@justeattakeaway/pie-webc": 0.5.23
3406934069
vite: 4.5.3
3407034070
languageName: unknown
3407134071
linkType: soft
@@ -34075,7 +34075,7 @@ __metadata:
3407534075
resolution: "wc-vue3@workspace:apps/examples/wc-vue3"
3407634076
dependencies:
3407734077
"@justeattakeaway/pie-css": 0.12.1
34078-
"@justeattakeaway/pie-webc": 0.5.24
34078+
"@justeattakeaway/pie-webc": 0.5.23
3407934079
"@types/node": 18.15.11
3408034080
"@vitejs/plugin-vue": 4.0.0
3408134081
"@vue/tsconfig": 0.1.3

0 commit comments

Comments
 (0)