Skip to content

Commit cdffcb5

Browse files
Merge branch 'main' into dsw-2307-pie-radio
2 parents 0cb4c91 + 8b1f579 commit cdffcb5

File tree

10 files changed

+46
-15
lines changed

10 files changed

+46
-15
lines changed

.changeset/neat-forks-add.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"pie-docs": minor
3+
---
4+
5+
[Changed] - Use only css to apply columns to docs site contents tables

.changeset/ninety-monkeys-run.md

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
"pie-storybook": patch
3+
"pie-docs": patch
4+
"pie-monorepo": patch
5+
---
6+
7+
[Changed] - Add caching for `generate:component-statuses` build.
8+
[Added] - New `copy:component-statuses` script for `pie-docs` and `pie-storybook` which copies the status file from the root.

apps/pie-docs/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"build:dev": "DEPLOYMENT_ENVIRONMENT='development' eleventy",
1313
"clean": "run -T rimraf dist",
1414
"dev": "npx @11ty/eleventy --serve --port=8080",
15-
"generate:component-statuses": "npx generate-component-statuses",
15+
"copy:component-statuses": "cp -v ../../component-statuses.json .",
1616
"lint:scripts": "run -T eslint .",
1717
"lint:scripts:fix": "run -T eslint . --fix",
1818
"lint:style": "run -T stylelint ./src/**/*.{css,scss}",

apps/pie-docs/src/assets/js/contents.js

-2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,4 @@ window.addEventListener('DOMContentLoaded', () => {
1414
item.setAttribute('data-title', textContent);
1515
}
1616
});
17-
18-
list[0].style.setProperty('--column-count', columns);
1917
});

apps/pie-docs/src/assets/styles/components/_contentList.scss

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ $tooltip-border-radius: 100px;
1313
max-width: $contentList-maxWidth;
1414

1515
ol {
16-
column-width: $contentList-column-width 1;
1716
column-gap: var(--dt-spacing-f);
1817
padding: 0;
1918
column-fill: auto;
19+
column-count: 1;
2020

2121
@include f.media('>=mid') {
2222
max-height: $contentList-maxHeight;
23-
column-count: var(--column-count);
23+
column-count: 3;
2424
}
2525
}
2626

apps/pie-docs/turbo.json

+8-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"dependsOn": [
1414
"^build",
1515
"clean",
16-
"generate:component-statuses"
16+
"copy:component-statuses"
1717
],
1818
"outputs": [
1919
"dist/**"
@@ -23,7 +23,7 @@
2323
"cache": true,
2424
"dependsOn": [
2525
"^build",
26-
"generate:component-statuses"
26+
"copy:component-statuses"
2727
]
2828
},
2929
"dev": {
@@ -32,6 +32,12 @@
3232
"build:dev"
3333
]
3434
},
35+
"copy:component-statuses": {
36+
"dependsOn": [
37+
"//#generate:component-statuses"
38+
],
39+
"cache": false
40+
},
3541
"test:generate-routes": {
3642
"cache": true,
3743
"dependsOn": [

apps/pie-storybook/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"build": "storybook build --output-dir dist && cp -R ./static ./dist",
99
"lint:scripts": "run -T eslint .",
1010
"lint:scripts:fix": "run -T eslint . --fix",
11-
"generate:component-statuses": "npx generate-component-statuses"
11+
"copy:component-statuses": "cp -v ../../component-statuses.json ."
1212
},
1313
"author": "Just Eat Takeaway.com - Design System Team",
1414
"license": "Apache-2.0",

apps/pie-storybook/turbo.json

+8-2
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,21 @@
88
"cache": false,
99
"dependsOn": [
1010
"^build",
11-
"generate:component-statuses"
11+
"copy:component-statuses"
1212
]
1313
},
1414
"build": {
1515
"cache": true,
1616
"dependsOn": [
1717
"^build",
18-
"generate:component-statuses"
18+
"copy:component-statuses"
1919
]
20+
},
21+
"copy:component-statuses": {
22+
"dependsOn": [
23+
"//#generate:component-statuses"
24+
],
25+
"cache": false
2026
}
2127
}
2228
}

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"clean": "turbo run clean --filter=!pie-monorepo",
3535
"cz": "./packages/tools/pie-git-hooks-scripts/check-branch-name.js $(git symbolic-ref --short HEAD) && ./node_modules/cz-customizable/standalone.js",
3636
"dev": "turbo run dev --filter=!pie-monorepo",
37+
"copy:component-statuses": "cross-env-shell turbo run copy:component-statuses --filter=!pie-monorepo",
3738
"generate:component-statuses": "npx generate-component-statuses",
3839
"generate:examples": "cross-env-shell turbo run generate:examples --filter=!pie-monorepo --token=${TURBO_TOKEN}",
3940
"lint:config:fix": "eslint --fix turbo.json (packages|apps)/**/turbo.json",

turbo.json

+12-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"dependsOn": [
77
"^build",
88
"build:react-wrapper",
9-
"generate:component-statuses"
9+
"//#generate:component-statuses"
1010
],
1111
"outputs": [
1212
"dist/**"
@@ -55,12 +55,19 @@
5555
".output/**"
5656
]
5757
},
58-
"generate:component-statuses": {
59-
"cache": false,
58+
"//#generate:component-statuses": {
59+
"cache": true,
60+
"inputs": [
61+
"packages/components/**/package.json",
62+
"!packages/components/pie-webc",
63+
"!packages/components/pie-webc-core",
64+
"!packages/components/pie-webc-testing"
65+
],
6066
"outputs": [
61-
"**/component-statuses.json"
67+
"component-statuses.json"
6268
]
6369
},
70+
"copy:component-statuses": {},
6471
"watch": {
6572
"cache": true,
6673
"dependsOn": []
@@ -167,7 +174,7 @@
167174
"cache": false,
168175
"dependsOn": [
169176
"^build",
170-
"generate:component-statuses"
177+
"//#generate:component-statuses"
171178
]
172179
}
173180
}

0 commit comments

Comments
 (0)