feat(pie-docs): DSW-000 css-only content tables #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c7e3e3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jamieomaguire
force-pushed
the
dsw-000-css-only-content-tables
branch
from
0625a1a to
9e8a208
Compare
jamieomaguire
commented
Sep 13, 2024
kevinrodrigues
approved these changes
Sep 13, 2024
dandel10n
approved these changes
Sep 13, 2024
maledr5
approved these changes
Sep 13, 2024
xander-marjoram
approved these changes
Sep 13, 2024
jamieomaguire
commented
Sep 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
Removes the usage of JS for setting column counts on the docs site table pages. This was causing jank on page load as the table starts as a single column list before JS boots up and fixes the render. Now it should always load at the correct column count before JS boots up.
Video demos:
Prod (current)
docs-site-prod.mov
With the changes
docs-site-fix.mov
Author Checklist (complete before requesting a review)
PIE Storybook/PIE DocsPR previewReviewer checklists (complete before approving)
Reviewer 1 @maledr5
PIE DocsPR previewReviewer 2
PIE DocsPR preview