Skip to content

Commit f97bb92

Browse files
authored
fix: improve error messaging for invalid semver tag (#18)
1 parent 9a206cf commit f97bb92

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

dist/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44185,7 +44185,7 @@ module.exports = async () => {
4418544185
}
4418644186

4418744187
if (!semver.valid(latestRelease.name)) {
44188-
return core.setFailed(`latest tag name is not valid semver: ${JSON.stringify(latestRelease)}`)
44188+
return core.setFailed(`latest tag name "${latestRelease.name}" is not valid semver. GitHub API response: ${JSON.stringify(latestRelease)}`)
4418944189
}
4419044190

4419144191
// get commits from last tag and calculate version bump

src/run.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ module.exports = async () => {
2929
}
3030

3131
if (!semver.valid(latestRelease.name)) {
32-
return core.setFailed(`latest tag name is not valid semver: ${JSON.stringify(latestRelease)}`)
32+
return core.setFailed(`latest tag name "${latestRelease.name}" is not valid semver. GitHub API response: ${JSON.stringify(latestRelease)}`)
3333
}
3434

3535
// get commits from last tag and calculate version bump

src/run.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ describe('run', () => {
5151
})
5252

5353
it('should fail when latest tag is no valid semver', async () => {
54-
github.getLatestRelease.mockResolvedValueOnce('invalid-semver')
54+
github.getLatestRelease.mockResolvedValueOnce({ name: 'invalid-semver' })
5555

5656
await run()
5757
expect(core.setFailed).toBeCalledTimes(1)
58-
expect(core.setFailed).toHaveBeenNthCalledWith(1, 'latest tag name is not valid semver: "invalid-semver"')
58+
expect(core.setFailed).toHaveBeenNthCalledWith(1, 'latest tag name "invalid-semver" is not valid semver. GitHub API response: {"name":"invalid-semver"}')
5959
})
6060

6161
it('should output versions', async () => {

0 commit comments

Comments
 (0)