This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Alias gray[0] as white and fix incorrect spelling for fuchsia #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I don't know if I agree that all the issues linked to above actually make sense for this library. I might try to take a look at this over the weekend |
|
Of course! Just let me know if you want me to change something or open separate PR's for this. Just in case this doesn't get merged and someone needs having |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of the opened issues on the repo and updates the tests so they'll pass with the new changes. It also removes a helper function that was only used once and wasn't really necessary. I accidentally pushed a change to
.gitignoretoo, I can remove it if you want.This closes #3, closes #8, closes #12, and closes #14.