From f1eeac2d6bc1a4d182636db9015dd82c3bc6663c Mon Sep 17 00:00:00 2001 From: mdp Date: Thu, 20 Mar 2025 15:02:32 -0300 Subject: [PATCH] modify validation condition for more meaningful logs and error handling. --- .../spotify/api/impl/PlaylistApiRetrofit.java | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/main/java/spotify/api/impl/PlaylistApiRetrofit.java b/src/main/java/spotify/api/impl/PlaylistApiRetrofit.java index 9530a4d..a7f5f23 100644 --- a/src/main/java/spotify/api/impl/PlaylistApiRetrofit.java +++ b/src/main/java/spotify/api/impl/PlaylistApiRetrofit.java @@ -178,8 +178,14 @@ public void addItemToPlaylist(List listOfObjectUris, String playlistId, @Override public void createPlaylist(String userId, CreateUpdatePlaylistRequestBody requestBody) { - if (userId == null || requestBody.getName() == null || userId.isEmpty() || requestBody.getName().isEmpty()) { - final String errorMessage = "Required parameters are empty!"; + if (userId == null || userId.isEmpty()) { + final String errorMessage = "userId can not be empty!"; + logger.error(errorMessage); + throw new IllegalArgumentException(errorMessage); + } + + if (requestBody.getName() == null || requestBody.getName().isEmpty()) { + final String errorMessage = "requestBody can not be empty!"; logger.error(errorMessage); throw new IllegalArgumentException(errorMessage); } @@ -293,8 +299,14 @@ public void replacePlaylistItems(String playlistId, List listOfItemUris) @Override public void uploadCoverImageToPlaylist(String playlistId, String base64EncodedJpegImage) { - if (playlistId == null || base64EncodedJpegImage == null || playlistId.isEmpty() || base64EncodedJpegImage.isEmpty()) { - final String errorMessage = "Required parameters are empty!"; + if (playlistId == null || playlistId.isEmpty()) { + final String errorMessage = "playlistId can not be empty!"; + logger.error(errorMessage); + throw new IllegalArgumentException(errorMessage); + } + + if (base64EncodedJpegImage == null || base64EncodedJpegImage.isEmpty()) { + final String errorMessage = "Image can not be empty!"; logger.error(errorMessage); throw new IllegalArgumentException(errorMessage); }