Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage #25

Closed
carlocorradini opened this issue Nov 14, 2023 · 9 comments · Fixed by #48
Closed

Code coverage #25

carlocorradini opened this issue Nov 14, 2023 · 9 comments · Fixed by #48

Comments

@carlocorradini
Copy link
Collaborator

@karljj1 Can you create an account on Codecov for kdis

Thanks 🥳🤗

@karljj1
Copy link
Owner

karljj1 commented Nov 14, 2023

Its setup. I added the secret, you just need to put it into the actions somewhere:

- name: Upload coverage reports to Codecov
  uses: codecov/codecov-action@v3
  env:
    CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

@carlocorradini
Copy link
Collaborator Author

Awesome.
Only to be certain, have you set up the Open Source project template for Codecov? (The token is not necessary if OSS)

@karljj1
Copy link
Owner

karljj1 commented Nov 16, 2023

Awesome. Only to be certain, have you set up the Open Source project template for Codecov? (The token is not necessary if OSS)

I dont see that option. There are 3 I can see: Github Actions, CircleCI and Other CI.
image

@carlocorradini
Copy link
Collaborator Author

@carlocorradini
Copy link
Collaborator Author

@karljj1 Can you install https://github.com/apps/codecov in the repo. Thanks

@karljj1
Copy link
Owner

karljj1 commented Nov 17, 2023

@karljj1 Can you install https://github.com/apps/codecov in the repo. Thanks

Is it all working now?

@carlocorradini
Copy link
Collaborator Author

@karljj1 Can you install https://github.com/apps/codecov in the repo. Thanks

Is it all working now?

It should be automatic :)

@carlocorradini
Copy link
Collaborator Author

@karljj1 Can you add the token to the ci (I've forgot to add it)
The file is in .GitHub/workflows/check.yml

@karljj1
Copy link
Owner

karljj1 commented Jan 20, 2025

Sorry, which token? I feel like I have forgotten everything 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants