Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change from KDIS_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR #7

Closed
carlocorradini opened this issue Sep 4, 2023 · 2 comments · Fixed by #10
Closed

feat: Change from KDIS_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR #7

carlocorradini opened this issue Sep 4, 2023 · 2 comments · Fixed by #10

Comments

@carlocorradini
Copy link
Collaborator

The value of KDIS_SOURCE_DIR is not set and can cause UB. Moreover it can cause strange inclue errors while using"auto-tools" like CPM.

From:

kdis/KDIS/CMakeLists.txt

Line 36 in 3cdfc0f

SET(BASE_DIR ${KDIS_SOURCE_DIR}/KDIS)

To:

SET(BASE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/KDIS)
@karljj1
Copy link
Owner

karljj1 commented Sep 11, 2023

It's been a long time since I touched this, ill have to look through it and see what its purpose was.
Im happy to take a PR to change it.

@carlocorradini
Copy link
Collaborator Author

I'll create a PR 🥳

@carlocorradini carlocorradini mentioned this issue Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: project structure, readme and license carlocorradini/kdis
2 participants
@karljj1 @carlocorradini