Added command to print complete recipe #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akshit42-hue <[email protected]>
Author
Author
|
Any updates @sahil-lakhwani @PrasadG193 :) |
Member
|
Thanks for the PR @Akshit42-hue. |
Signed-off-by: Akshit42-hue <[email protected]>
Author
|
Mergify is still failing. How can I fix it? @PrasadG193 |
PrasadG193
reviewed
Nov 7, 2022
Member
PrasadG193
left a comment
PrasadG193
left a comment
There was a problem hiding this comment.
@Akshit42-hue could you please add a sample output of the command for existing and missing recipe in the PR description?
| path := info[0].Path | ||
| // fs,e os.OpenFile(path) | ||
| data, err := os.ReadFile(path) | ||
| check(err) |
Member
There was a problem hiding this comment.
It should not panic. Rather return and handle err
| return "", fmt.Errorf("no recipe found for %s", appName) | ||
| } | ||
| path := info[0].Path | ||
| // fs,e os.OpenFile(path) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akshit42-hue [email protected]
Fixes #120