fix(notion): make plugin work properly even with unsupported proprty types

Author: kerwanp

packages/@contentlayer/source-notion/src/schema/provideDatabaseFieldSchema.ts

@@ -1,12 +1,12 @@
 import type { OT } from "@contentlayer/utils/effect";
 import { pipe, T } from "@contentlayer/utils/effect";
 
-import { getFieldFunctions } from "../mapping";
-import type { DatabaseProperties, FieldDef } from "../types";
-import type { ProvideDatabaseSchemaArgs } from "./provideDatabaseSchema";
-import type { DatabaseTypeDef } from "./types";
-import { findDatabaseFieldDef } from "./utils/findDatabaseFieldDef";
-import { normalizeKey } from "./utils/normalizeKey";
+import { getFieldFunctions } from "../mapping/index.js";
+import type { DatabaseProperties, FieldDef } from "../types.js";
+import type { ProvideDatabaseSchemaArgs } from "./provideDatabaseSchema.js";
+import type { DatabaseTypeDef } from "./types.js";
+import { findDatabaseFieldDef } from "./utils/findDatabaseFieldDef.js";
+import { normalizeKey } from "./utils/normalizeKey.js";
 
 export type ProvideDatabaseFieldSchemaArgs = {
     property: DatabaseProperties
@@ -15,11 +15,13 @@ export type ProvideDatabaseFieldSchemaArgs = {
 
 export const provideDatabaseFieldSchema =
     ({ property, databaseTypeDef, ...rest }: ProvideDatabaseFieldSchemaArgs):
-        T.Effect<OT.HasTracer, unknown, FieldDef> => pipe(
+        T.Effect<OT.HasTracer, unknown, FieldDef | undefined> => pipe(
             T.succeed(findDatabaseFieldDef({ databaseTypeDef, property })),
             T.chain((databaseFieldTypeDef) => pipe(
                 T.succeed(getFieldFunctions(property.type)?.getFieldDef({ property, databaseFieldTypeDef, databaseTypeDef, ...rest })),
                 T.map((def) => {
+                    if (!def) return; // TODO : Find a more beautiful way using ts-effects
+
                     const name = normalizeKey(databaseFieldTypeDef?.key ?? property.name);
 
                     return {

packages/@contentlayer/source-notion/src/schema/provideDatabaseSchema.ts

@@ -1,10 +1,11 @@
 import type * as core from '@contentlayer/core'
+import type { FieldDef } from '@contentlayer/core';
 import type { OT } from "@contentlayer/utils/effect";
 import { pipe, T } from "@contentlayer/utils/effect";
 
-import { provideDatabaseFieldSchema } from './provideDatabaseFieldSchema';
-import type { ProvideSchemaArgs } from "./provideSchema";
-import type { DatabaseTypeDef } from "./types";
+import { provideDatabaseFieldSchema } from './provideDatabaseFieldSchema.js';
+import type { ProvideSchemaArgs } from "./provideSchema.js";
+import type { DatabaseTypeDef } from "./types.js";
 
 export type ProvideDatabaseSchemaArgs = {
     databaseTypeDef: DatabaseTypeDef
@@ -23,7 +24,7 @@ export const provideDatabaseSchema =
                     name: databaseTypeDef.name,
                     description: databaseTypeDef.description,
                     isSingleton: false,
-                    fieldDefs: [...def],
+                    fieldDefs: [...def].filter(def => !!def) as FieldDef[], // TODO : Find a more beautiful way
                     computedFields: [],
                     extensions: {}
                 }))